Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2708883005: Handle nested position:sticky elements correctly (main thread) (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index ac03b02a63fada3e05335e07899878a16129e44e..6e66dcecbf1827f0aa76ed281430a9a10e05164a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -2076,6 +2076,13 @@ void LayoutObject::mapLocalToAncestor(const LayoutBoxModelObject* ancestor,
}
LayoutSize containerOffset = offsetFromContainer(container);
+
+ // TODO(smcgruer): This is inefficient. Instead we should avoid including
+ // offsetForInFlowPosition in offsetFromContainer when ignoring sticky.
+ if (mode & IgnoreStickyOffset && isStickyPositioned()) {
+ containerOffset -= toLayoutBoxModelObject(this)->offsetForInFlowPosition();
+ }
+
if (isLayoutFlowThread()) {
// So far the point has been in flow thread coordinates (i.e. as if
// everything in the fragmentation context lived in one tall single column).

Powered by Google App Engine
This is Rietveld 408576698