third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2708883005: Handle nested position:sticky elements correctly (main thread)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2708883005: Handle nested position:sticky elements correctly (main thread) (Closed)

Patch Set: Address reviewer comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutObject.cpp ('K') | « third_party/WebKit/Source/core/layout/MapCoordinatesFlags.h ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index 60bc7d9c1f0b10387e35cea5af6102cff05cc949..598396b9a37962b29489f99dcc8968782803c6bd 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -345,6 +345,7 @@ void CompositedLayerMapping::updateStickyConstraints(

enclosingIntRect(constraints.scrollContainerRelativeStickyBoxRect());

webConstraint.scrollContainerRelativeContainingBlockRect = enclosingIntRect(

constraints.scrollContainerRelativeContainingBlockRect());

+ // TODO(smcgruer): Copy fields for nested sticky in cc (crbug.com/672710)

}

m_graphicsLayer->setStickyPositionConstraint(webConstraint);