Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2708883005: Handle nested position:sticky elements correctly (main thread) (Closed)
Patch Set: Address reviewer comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 29ddba69decec3a8f4fbbd0b60c08dd5bb9df356..707c7afd3c58112429dd093c56fba41bcd286b24 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -1957,11 +1957,20 @@ void FrameView::updateLayersAndCompositingAfterScrollIfNeeded() {
if (!hasViewportConstrainedObjects())
return;
- // Update sticky position objects which are stuck to the viewport.
+ // Update sticky position objects which are stuck to the viewport. In order to
+ // correctly compute the sticky position offsets the layers must be visited
+ // top-down, so start at the 'root' sticky elements and recurse downwards.
for (const auto& viewportConstrainedObject : *m_viewportConstrainedObjects) {
LayoutObject* layoutObject = viewportConstrainedObject;
+ if (layoutObject->style()->position() != EPosition::kSticky)
+ continue;
+
PaintLayer* layer = toLayoutBoxModelObject(layoutObject)->layer();
- if (layoutObject->style()->position() == EPosition::kSticky) {
+ StickyConstraintsMap constraintsMap = layer->ancestorOverflowLayer()
+ ->getScrollableArea()
+ ->stickyConstraintsMap();
+ if (constraintsMap.contains(layer) &&
+ !constraintsMap.get(layer).hasAncestorStickyElement()) {
// TODO(skobes): Resolve circular dependency between scroll offset and
// compositing state, and remove this disabler. https://crbug.com/420741
DisableCompositingQueryAsserts disabler;

Powered by Google App Engine
This is Rietveld 408576698