Network traffic annotation added to feedback_uploader_chrome.

components/feedback/feedback_uploader_chrome.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/feedback/feedback_uploader_chrome.h"
 
 #include <string>
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/task_runner_util.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "components/feedback/feedback_report.h"
 #include "components/feedback/feedback_switches.h"
 #include "components/feedback/feedback_uploader_delegate.h"
 #include "components/variations/net/variations_http_headers.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/storage_partition.h"
 #include "net/base/load_flags.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "url/gurl.h"
 
 using content::BrowserThread;
 
 namespace feedback {
 namespace {
 
 const char kProtoBufMimeType[] = "application/x-protobuf";
 
 }  // namespace
 
 FeedbackUploaderChrome::FeedbackUploaderChrome(
     content::BrowserContext* context)
     : FeedbackUploader(context ? context->GetPath() : base::FilePath(),
                        BrowserThread::GetBlockingPool()),
       context_(context) {
   CHECK(context_);
   const base::CommandLine& command_line =
       *base::CommandLine::ForCurrentProcess();
   if (command_line.HasSwitch(switches::kFeedbackServer))
     url_ = command_line.GetSwitchValueASCII(switches::kFeedbackServer);
 }
 
 void FeedbackUploaderChrome::DispatchReport(const std::string& data) {
   GURL post_url(url_);
 
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("chrome_feedback_report_app", R"(
+        semantics {
+          sender: "Chrome Feedback Report App"
+          description:
+            "This uploads the feedback report to Google feedback server."

[Ramin Halavati, 2017/03/11 09:42:54]

May be it would be good if you describe what is the feedback about. This text
should be clear enough so that a non-very-technical person finds out why this
data is sent.

[afakhry, 2017/03/14 01:36:42]

I'm not sure how to describe it in a simple way. This is the feedback report
sent by the user when he presses Alt+Shift+i to report a bug or a feedback in
general. Along with it is sent system logs that helps us to diagnose the issue.

[Ramin Halavati, 2017/03/14 06:31:57]

Thank you, I think this description is quite good. I updated the text based on
this.

+          trigger: "When the feedback report is being uploaded."

[Ramin Halavati, 2017/03/11 09:42:54]

Is user asked for sending feedback? In which cases feedback is generated?

[afakhry, 2017/03/14 01:36:42]

This is a user-generated event, as a result of pressing Alt+Shift+i. See
https://support.google.com/chrome/answer/95315?hl=en

[Ramin Halavati, 2017/03/14 06:31:57]

Done.

+          data:
+            "Contents of the report, user entered message, and useful "

[Ramin Halavati, 2017/03/11 09:42:54]

Can you add details on content items? Is there any user specific data?

[afakhry, 2017/03/14 01:36:42]

We anonymize the logs to remove any user-private data. The user can view the
system information before sending, and can choose to send the feedback report
without the logs, the screenshot, or even his email address.

[Ramin Halavati, 2017/03/14 06:31:57]

Done.

+            "debugging logs."
+          destination: GOOGLE_OWNED_SERVICE
+        }
+        policy {
+          cookies_allowed: false
+          setting: "..."

[Ramin Halavati, 2017/03/11 09:42:54]

I didn't find any settings disabling feedback, is there? Or can we add this
feedback is sent only by direct approval of the user.?

[afakhry, 2017/03/14 01:36:42]

I'm not aware of any setting to disable feedback.
Yes, we can add that.
I vaguely remember that in kiosk devices, some feedback reports are sent
periodically in the background, but I think for that to happen the user has to
be opt-in. +rkc@ who might know more about this.

[Ramin Halavati, 2017/03/14 06:31:57]

Acknowledged.

+          policy_exception_justification: "Not implemented."
+        })");
   // Note: FeedbackUploaderDelegate deletes itself and the fetcher.
   net::URLFetcher* fetcher =
       net::URLFetcher::Create(
           post_url, net::URLFetcher::POST,
           new FeedbackUploaderDelegate(
-              data, base::Bind(&FeedbackUploaderChrome::UpdateUploadTimer,
-                               AsWeakPtr()),
-              base::Bind(&FeedbackUploaderChrome::RetryReport, AsWeakPtr())))
+              data,
+              base::Bind(&FeedbackUploaderChrome::UpdateUploadTimer,
+                         AsWeakPtr()),
+              base::Bind(&FeedbackUploaderChrome::RetryReport, AsWeakPtr())),
+          traffic_annotation)
           .release();
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher, data_use_measurement::DataUseUserData::FEEDBACK_UPLOADER);
   // Tell feedback server about the variation state of this install.
   net::HttpRequestHeaders headers;
   // Note: It's OK to pass |is_signed_in| false if it's unknown, as it does
   // not affect transmission of experiments coming from the variations server.
   bool is_signed_in = false;
   variations::AppendVariationHeaders(fetcher->GetOriginalURL(),
                                      context_->IsOffTheRecord(), false,
                                      is_signed_in, &headers);
   fetcher->SetExtraRequestHeaders(headers.ToString());
 
   fetcher->SetUploadData(kProtoBufMimeType, data);
   fetcher->SetRequestContext(
       content::BrowserContext::GetDefaultStoragePartition(context_)->
           GetURLRequestContext());
   fetcher->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES |
                         net::LOAD_DO_NOT_SEND_COOKIES);
   fetcher->Start();
 }
 
 }  // namespace feedback