Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1410)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 270883003: Decouple RVH creation from CrossProcessFrameConnector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Some more cleanup and fixes. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index bf4312e12121da4a94101c8ee0e2846a435ef8ec..32a4ea3548c7e8f8cd4350a8b42a95347cb82df0 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -21,6 +21,7 @@
#include "content/browser/frame_host/render_frame_host_factory.h"
#include "content/browser/frame_host/render_frame_host_impl.h"
#include "content/browser/frame_host/render_frame_proxy_host.h"
+#include "content/browser/frame_host/render_widget_host_view_child_frame.h"
#include "content/browser/renderer_host/render_process_host_impl.h"
#include "content/browser/renderer_host/render_view_host_factory.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
@@ -33,6 +34,7 @@
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
#include "content/public/browser/render_widget_host_iterator.h"
+#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/user_metrics.h"
#include "content/public/browser/web_ui_controller.h"
#include "content/public/common/content_switches.h"
@@ -178,7 +180,8 @@ RenderFrameHostImpl* RenderFrameHostManager::Navigate(
// Note: we don't call InitRenderView here because we are navigating away
// soon anyway, and we don't have the NavigationEntry for this host.
delegate_->CreateRenderViewForRenderManager(
- render_frame_host_->render_view_host(), MSG_ROUTING_NONE, NULL);
+ render_frame_host_->render_view_host(), MSG_ROUTING_NONE,
+ frame_tree_node_->IsMainFrame());
}
// If the renderer crashed, then try to create a new one to satisfy this
@@ -188,7 +191,7 @@ RenderFrameHostImpl* RenderFrameHostManager::Navigate(
int opener_route_id = delegate_->CreateOpenerRenderViewsForRenderManager(
dest_render_frame_host->GetSiteInstance());
if (!InitRenderView(dest_render_frame_host->render_view_host(),
- opener_route_id))
+ opener_route_id, frame_tree_node_->IsMainFrame()))
return NULL;
// Now that we've created a new renderer, be sure to hide it if it isn't
@@ -935,7 +938,8 @@ int RenderFrameHostManager::CreateRenderFrame(
new_render_frame_host.Pass());
}
- bool success = InitRenderView(render_view_host, opener_route_id);
+ bool success = InitRenderView(
+ render_view_host, opener_route_id, frame_tree_node_->IsMainFrame());
if (success && frame_tree_node_->IsMainFrame()) {
// Don't show the main frame's view until we get a DidNavigate from it.
render_view_host->GetView()->Hide();
@@ -953,7 +957,8 @@ int RenderFrameHostManager::CreateRenderFrame(
}
bool RenderFrameHostManager::InitRenderView(RenderViewHost* render_view_host,
- int opener_route_id) {
+ int opener_route_id,
+ bool main_frame) {
// We may have initialized this RenderViewHost for another RenderFrameHost.
if (render_view_host->IsRenderViewLive())
return true;
@@ -975,7 +980,7 @@ bool RenderFrameHostManager::InitRenderView(RenderViewHost* render_view_host,
}
return delegate_->CreateRenderViewForRenderManager(
- render_view_host, opener_route_id, cross_process_frame_connector_);
+ render_view_host, opener_route_id, main_frame);
}
void RenderFrameHostManager::CommitPending() {
@@ -1132,6 +1137,16 @@ void RenderFrameHostManager::CommitPending() {
old_render_frame_host.reset();
ShutdownRenderFrameHostsInSiteInstance(old_site_instance_id);
} else {
+ // If this is a subframe, it should have a CrossProcessFrameConnector
+ // created already and we just need to link it to the proper view in the
+ // new process.
+ if (!is_main_frame) {
+ RenderWidgetHostView* rwhv =
+ render_frame_host_->render_view_host()->GetView();
+ RenderWidgetHostViewChildFrame* rwhv_child =
+ static_cast<RenderWidgetHostViewChildFrame*>(rwhv);
+ cross_process_frame_connector_->set_view(rwhv_child);
+ }
proxy_hosts_[old_site_instance_id] = new RenderFrameProxyHost(
old_render_frame_host.Pass());
}

Powered by Google App Engine
This is Rietveld 408576698