Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 270883003: Decouple RVH creation from CrossProcessFrameConnector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing based on Charlie's review. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index 598dbd415f159650f479814b86f0e15640a34440..b331b8d7b7a718a1d797f47b11d53720c3cf23a6 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -57,14 +57,16 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
// corresponding to this view host. If this method is not called and the
// process is not shared, then the WebContentsImpl will act as though the
// renderer is not running (i.e., it will render "sad tab"). This method is
- // automatically called from LoadURL.
+ // automatically called from LoadURL. |main_frame| indicates whether this
+ // RenderViewHost is used to render a top-level frame, so the appropriate
+ // RenderWidgetHostView type is used.
//
// If you are attaching to an already-existing RenderView, you should call
// InitWithExistingID.
virtual bool CreateRenderViewForRenderManager(
RenderViewHost* render_view_host,
int opener_route_id,
- CrossProcessFrameConnector* cross_process_frame_connector) = 0;
+ bool for_main_frame) = 0;
virtual void BeforeUnloadFiredFromRenderManager(
bool proceed, const base::TimeTicks& proceed_time,
bool* proceed_to_fire_unload) = 0;
@@ -377,7 +379,9 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
// initialized for another RenderFrameHost.
// TODO(creis): opener_route_id is currently for the RenderViewHost but should
// be for the RenderFrame, since frames can have openers.
- bool InitRenderView(RenderViewHost* render_view_host, int opener_route_id);
+ bool InitRenderView(RenderViewHost* render_view_host,
+ int opener_route_id,
+ bool for_main_frame);
// Sets the pending RenderFrameHost/WebUI to be the active one. Note that this
// doesn't require the pending render_frame_host_ pointer to be non-NULL,

Powered by Google App Engine
This is Rietveld 408576698