Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: content/browser/frame_host/cross_process_frame_connector.cc

Issue 270883003: Decouple RVH creation from CrossProcessFrameConnector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/cross_process_frame_connector.cc
diff --git a/content/browser/frame_host/cross_process_frame_connector.cc b/content/browser/frame_host/cross_process_frame_connector.cc
index 19fcdf0d4b07713fe2cabee147f26ad574deec00..228bf5d275ac8f19697bbf0956cca630deef9758 100644
--- a/content/browser/frame_host/cross_process_frame_connector.cc
+++ b/content/browser/frame_host/cross_process_frame_connector.cc
@@ -19,6 +19,9 @@ CrossProcessFrameConnector::CrossProcessFrameConnector(
: frame_proxy_in_parent_renderer_(frame_proxy_in_parent_renderer),
view_(NULL),
device_scale_factor_(1) {
+ LOG(ERROR) << "CPFC::CPFC[" << this << "]:"
+ << " rfh:" << frame_proxy_in_parent_renderer;
+
frame_proxy_in_parent_renderer->set_cross_process_frame_connector(this);
}
@@ -124,19 +127,23 @@ void CrossProcessFrameConnector::OnReclaimCompositorResources(
void CrossProcessFrameConnector::OnInitializeChildFrame(gfx::Rect frame_rect,
float scale_factor) {
+ LOG(ERROR) << "CPFC::OnInitializeChildFrame[" << this << "]";
if (scale_factor != device_scale_factor_) {
device_scale_factor_ = scale_factor;
if (view_) {
RenderWidgetHostImpl* child_widget =
RenderWidgetHostImpl::From(view_->GetRenderWidgetHost());
child_widget->NotifyScreenInfoChanged();
+ LOG(ERROR) << "CPFC::OnInitializeChildFrame[" << this << "]: notify";
}
}
if (!frame_rect.size().IsEmpty()) {
child_frame_rect_ = frame_rect;
- if (view_)
+ if (view_) {
view_->SetSize(frame_rect.size());
+ LOG(ERROR) << "CPFC::OnInitializeChildFrame[" << this << "]: set size";
+ }
}
}
@@ -146,6 +153,7 @@ gfx::Rect CrossProcessFrameConnector::ChildFrameRect() {
void CrossProcessFrameConnector::OnForwardInputEvent(
const blink::WebInputEvent* event) {
+ LOG(ERROR) << "CPFC::OnForwardInputEvent[" << this << "]: " << view_;
if (!view_)
return;
@@ -160,18 +168,21 @@ void CrossProcessFrameConnector::OnForwardInputEvent(
NativeWebKeyboardEvent keyboard_event(
*parent_widget->GetLastKeyboardEvent());
child_widget->ForwardKeyboardEvent(keyboard_event);
+ LOG(ERROR) << "CPFC::OnForwardInputEvent[" << this << "]: kbd";
return;
}
if (blink::WebInputEvent::isMouseEventType(event->type)) {
child_widget->ForwardMouseEvent(
*static_cast<const blink::WebMouseEvent*>(event));
+ LOG(ERROR) << "CPFC::OnForwardInputEvent[" << this << "]: mouse";
return;
}
if (event->type == blink::WebInputEvent::MouseWheel) {
child_widget->ForwardWheelEvent(
*static_cast<const blink::WebMouseWheelEvent*>(event));
+ LOG(ERROR) << "CPFC::OnForwardInputEvent[" << this << "]: wheel";
return;
}
}

Powered by Google App Engine
This is Rietveld 408576698