Decouple RVH creation from CrossProcessFrameConnector.

content/browser/frame_host/cross_process_frame_connector.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/cross_process_frame_connector.h"
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
@@ skipping 36 matching lines @@
 }
 
 void CrossProcessFrameConnector::set_view(
     RenderWidgetHostViewChildFrame* view) {
   // Detach ourselves from the previous |view_|.
   if (view_)
     view_->set_cross_process_frame_connector(NULL);
 
   view_ = view;
 
-  // Attach ourselves to the new view.
-  if (view_)
+  // Attach ourselves to the new view and size it appropriately.
+  if (view_) {
     view_->set_cross_process_frame_connector(this);
+    OnInitializeChildFrame(child_frame_rect_, device_scale_factor_);

[ncarter (slow), 2014/05/10 00:32:43]

|device_scale_factor_| will be ignored by OnInitializeChildFrame because of its
idempotence check. It doesn't matter in practice, I think, because of how
RenderWidgetHostImpl will look up the screen_info_ on the first WasResized() --
but I think it might be best to avoid this pattern anyhow.

So it might be better to have both OnInitializeChildFrame and this function call
into a shared helper that updates the view based on the values of
child_frame_rect_ and device_scale_factor_ ? Or something like that?

[nasko, 2014/05/16 16:17:30]

Done.

+  }
 }
 
 void CrossProcessFrameConnector::RenderProcessGone() {
   frame_proxy_in_parent_renderer_->Send(new FrameMsg_ChildFrameProcessGone(
       frame_proxy_in_parent_renderer_->routing_id()));
 }
 
 void CrossProcessFrameConnector::ChildFrameBuffersSwapped(
     const GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params& gpu_params,
     int gpu_host_id) {
@@ skipping 100 matching lines @@
   }
 
   if (event->type == blink::WebInputEvent::MouseWheel) {
     child_widget->ForwardWheelEvent(
         *static_cast<const blink::WebMouseWheelEvent*>(event));
     return;
   }
 }
 
 }  // namespace content