Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 270883003: Decouple RVH creation from CrossProcessFrameConnector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing based on Charlie's review. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 503 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 virtual void DidSendScreenRects(RenderWidgetHostImpl* rwh) OVERRIDE; 514 virtual void DidSendScreenRects(RenderWidgetHostImpl* rwh) OVERRIDE;
515 #if defined(OS_WIN) 515 #if defined(OS_WIN)
516 virtual gfx::NativeViewAccessible GetParentNativeViewAccessible() OVERRIDE; 516 virtual gfx::NativeViewAccessible GetParentNativeViewAccessible() OVERRIDE;
517 #endif 517 #endif
518 518
519 // RenderFrameHostManager::Delegate ------------------------------------------ 519 // RenderFrameHostManager::Delegate ------------------------------------------
520 520
521 virtual bool CreateRenderViewForRenderManager( 521 virtual bool CreateRenderViewForRenderManager(
522 RenderViewHost* render_view_host, 522 RenderViewHost* render_view_host,
523 int opener_route_id, 523 int opener_route_id,
524 CrossProcessFrameConnector* frame_connector) OVERRIDE; 524 bool for_main_frame) OVERRIDE;
525 virtual void BeforeUnloadFiredFromRenderManager( 525 virtual void BeforeUnloadFiredFromRenderManager(
526 bool proceed, const base::TimeTicks& proceed_time, 526 bool proceed, const base::TimeTicks& proceed_time,
527 bool* proceed_to_fire_unload) OVERRIDE; 527 bool* proceed_to_fire_unload) OVERRIDE;
528 virtual void RenderProcessGoneFromRenderManager( 528 virtual void RenderProcessGoneFromRenderManager(
529 RenderViewHost* render_view_host) OVERRIDE; 529 RenderViewHost* render_view_host) OVERRIDE;
530 virtual void UpdateRenderViewSizeForRenderManager() OVERRIDE; 530 virtual void UpdateRenderViewSizeForRenderManager() OVERRIDE;
531 virtual void CancelModalDialogsForRenderManager() OVERRIDE; 531 virtual void CancelModalDialogsForRenderManager() OVERRIDE;
532 virtual void NotifySwappedFromRenderManager( 532 virtual void NotifySwappedFromRenderManager(
533 RenderViewHost* old_host, RenderViewHost* new_host) OVERRIDE; 533 RenderViewHost* old_host, RenderViewHost* new_host) OVERRIDE;
534 virtual int CreateOpenerRenderViewsForRenderManager( 534 virtual int CreateOpenerRenderViewsForRenderManager(
(...skipping 563 matching lines...) Expand 10 before | Expand all | Expand 10 after
1098 bool last_dialog_suppressed_; 1098 bool last_dialog_suppressed_;
1099 1099
1100 scoped_ptr<GeolocationDispatcherHost> geolocation_dispatcher_host_; 1100 scoped_ptr<GeolocationDispatcherHost> geolocation_dispatcher_host_;
1101 1101
1102 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl); 1102 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl);
1103 }; 1103 };
1104 1104
1105 } // namespace content 1105 } // namespace content
1106 1106
1107 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1107 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698