Issue 270883002: Upstream base implementations of TabModel, TabModelSelector, and TabModelObserver.

Issue 270883002: Upstream base implementations of TabModel, TabModelSelector, and TabModelObserver. (Closed)

Created:
6 years, 7 months ago by Bernhard Bauer

Modified:
6 years, 7 months ago

Reviewers:
Ted C, David Trainor- moved to gerrit, Yaron

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Upstream base implementations of TabModel, TabModelSelector, and TabModelObserver. BUG=318769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270076

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : sync #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1496 lines, -3 lines)			Patch
A	chrome/android/java/src/org/chromium/chrome/browser/tabmodel/EmptyTabModel.java	View		1 chunk	+136 lines, -0 lines	0 comments	Download
A	chrome/android/java/src/org/chromium/chrome/browser/tabmodel/EmptyTabModelObserver.java	View		1 chunk	+52 lines, -0 lines	0 comments	Download
A	chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java	View		1 chunk	+638 lines, -0 lines	0 comments	Download
A	chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelDelegate.java	View	1	1 chunk	+39 lines, -0 lines	0 comments	Download
A	chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java	View	1	1 chunk	+146 lines, -0 lines	0 comments	Download
A	chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java	View	1	1 chunk	+171 lines, -0 lines	0 comments	Download
A	chrome/android/java/src/org/chromium/chrome/browser/util/MathUtils.java	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download
M	chrome/browser/android/chrome_jni_registrar.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/android/tab_model/tab_model.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A	chrome/browser/ui/android/tab_model/tab_model_base.h	View		1 chunk	+68 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/android/tab_model/tab_model_base.cc	View		1 chunk	+189 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

On 2014/05/12 22:57:13, Yaron wrote: > lgtm assuming it's a straight move and package update ...

6 years, 7 months ago (2014-05-13 12:38:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/270883002/40001

6 years, 7 months ago (2014-05-13 12:38:30 UTC) #5

Message was sent while issue was closed.

Change committed as 270076

Expand Messages | Collapse Messages