third_party/WebKit/Source/core/editing/SelectionModifier.h - Issue 2708823003: Make SelecitonModifier class not to use VisibleSelection::setBase() and setExtent()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/SelectionModifier.h

Issue 2708823003: Make SelecitonModifier class not to use VisibleSelection::setBase() and setExtent() (Closed)

Patch Set: 2017-02-22T13:59:38 Follow review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/SelectionModifier.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights	2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights

3 * reserved.	3 * reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 LayoutUnit lineDirectionPointForBlockDirectionNavigation(EPositionType);	73 LayoutUnit lineDirectionPointForBlockDirectionNavigation(EPositionType);

74 VisiblePosition modifyExtendingRight(TextGranularity);	74 VisiblePosition modifyExtendingRight(TextGranularity);

75 VisiblePosition modifyExtendingForward(TextGranularity);	75 VisiblePosition modifyExtendingForward(TextGranularity);

76 VisiblePosition modifyMovingRight(TextGranularity);	76 VisiblePosition modifyMovingRight(TextGranularity);

77 VisiblePosition modifyMovingForward(TextGranularity);	77 VisiblePosition modifyMovingForward(TextGranularity);

78 VisiblePosition modifyExtendingLeft(TextGranularity);	78 VisiblePosition modifyExtendingLeft(TextGranularity);

79 VisiblePosition modifyExtendingBackward(TextGranularity);	79 VisiblePosition modifyExtendingBackward(TextGranularity);

80 VisiblePosition modifyMovingLeft(TextGranularity);	80 VisiblePosition modifyMovingLeft(TextGranularity);

81 VisiblePosition modifyMovingBackward(TextGranularity);	81 VisiblePosition modifyMovingBackward(TextGranularity);

82 VisiblePosition nextWordPositionForPlatform(const VisiblePosition&);	82 VisiblePosition nextWordPositionForPlatform(const VisiblePosition&);

83 void willBeModified(EAlteration, SelectionDirection);

84	83

85 Member<LocalFrame> m_frame;	84 Member<LocalFrame> m_frame;

86 VisibleSelection m_selection;	85 VisibleSelection m_selection;

87 LayoutUnit m_xPosForVerticalArrowNavigation;	86 LayoutUnit m_xPosForVerticalArrowNavigation;

88	87

89 DISALLOW_COPY_AND_ASSIGN(SelectionModifier);	88 DISALLOW_COPY_AND_ASSIGN(SelectionModifier);

90 };	89 };

91	90

92 LayoutUnit NoXPosForVerticalArrowNavigation();	91 LayoutUnit NoXPosForVerticalArrowNavigation();

93	92

94 } // namespace blink	93 } // namespace blink

95	94

96 #endif // SelectionModifier_h	95 #endif // SelectionModifier_h

OLD	NEW