Fix infinite loop when there is a cycle in the class hierarchy (issue 28837)

Fix infinite loop when there is a cycle in the class hierarchy (issue 28837)

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/30bbc5858147b2f8624190a48d8b9c83be43dc60

[Brian Wilkerson, 2017-02-20 18:21:41]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-02-20 18:27:02]

LGTM!

https://codereview.chromium.org/2708773002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2708773002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:6414: Set<ClassElement>
visitedClasses = new Set();
Type argument in creation?

[Brian Wilkerson, 2017-02-20 19:46:30]

https://codereview.chromium.org/2708773002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2708773002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:6414: Set<ClassElement>
visitedClasses = new Set();
Done

[Brian Wilkerson, 2017-02-20 19:46:40]

Description was changed from

==========
Fix infinite loop when there is a cycle in the class hierarchy (issue 28837)
==========

to

==========
Fix infinite loop when there is a cycle in the class hierarchy (issue 28837)

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/30bbc5858147b2f8624190a48d8b9c83be43dc60
==========

[Brian Wilkerson, 2017-02-20 19:46:42]

Committed patchset #1 (id:1) manually as
30bbc5858147b2f8624190a48d8b9c83be43dc60 (presubmit successful).