Initializes the context of WorkerScriptController before calling willEvaluateWorkerScript.

Source/bindings/v8/WorkerScriptController.cpp

Index: Source/bindings/v8/WorkerScriptController.cpp
diff --git a/Source/bindings/v8/WorkerScriptController.cpp b/Source/bindings/v8/WorkerScriptController.cpp
index 6a07e3a1f7759a88d7a52e482a503997926fcc0a..89931f3d6613b4e4d9d40ff938a0126740dd8d07 100644
--- a/Source/bindings/v8/WorkerScriptController.cpp
+++ b/Source/bindings/v8/WorkerScriptController.cpp
@@ -113,7 +113,7 @@ WorkerScriptController::~WorkerScriptController()
     ThreadState::current()->addCleanupTask(IsolateCleanupTask::create(m_isolate));
 }
 
-bool WorkerScriptController::initializeContextIfNeeded()
+bool WorkerScriptController::initializeContext()
 {
     v8::HandleScope handleScope(m_isolate);
 
@@ -155,8 +155,7 @@ bool WorkerScriptController::initializeContextIfNeeded()
 
 ScriptValue WorkerScriptController::evaluate(const String& script, const String& fileName, const TextPosition& scriptStartPosition, WorkerGlobalScopeExecutionState* state)
 {
-    if (!initializeContextIfNeeded())
-        return ScriptValue();
+    ASSERT(isContextInitialized());

[haraken, 2014/05/09 10:03:22]

I think it's OK to call initializeContext from WorkerThread.cpp, but I don't
think it's OK to assume that context is initialized when evaluate() is called.

WorkerThread is not the only caller of evaluate(), so it's (probably
potentially) possible that other callers call evaluate() without initializing
context.

How about:

- Keep the name "initializeContextIfNeeded" as is.
- Keep WorkerScriptController::evaluate() as is.
- Call initializeContextIfNeeded() from WorkerThread.cpp.

?

[horo, 2014/05/09 10:22:00]

That sounds reasonable.
Done.

 
     ScriptState::Scope scope(m_scriptState.get());