Initializes the context of WorkerScriptController before calling willEvaluateWorkerScript.

Initializes the context of WorkerScriptController before calling willEvaluateWorkerScript.

This change will fix the crash bug on Debug build while reattaching DevTools to SharedWorker and dedicated worker.
See: https://code.google.com/p/chromium/issues/detail?id=371399#c8

BUG=371399
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173851

[horo, 2014-05-09 09:56:39]

dimich@, haraken@
Could you please review this?
Thank you.

[haraken, 2014-05-09 10:03:22]

https://codereview.chromium.org/270873005/diff/1/Source/bindings/v8/WorkerScr...
File Source/bindings/v8/WorkerScriptController.cpp (right):

https://codereview.chromium.org/270873005/diff/1/Source/bindings/v8/WorkerScr...
Source/bindings/v8/WorkerScriptController.cpp:158:
ASSERT(isContextInitialized());

I think it's OK to call initializeContext from WorkerThread.cpp, but I don't
think it's OK to assume that context is initialized when evaluate() is called.

WorkerThread is not the only caller of evaluate(), so it's (probably
potentially) possible that other callers call evaluate() without initializing
context.

How about:

- Keep the name "initializeContextIfNeeded" as is.
- Keep WorkerScriptController::evaluate() as is.
- Call initializeContextIfNeeded() from WorkerThread.cpp.

?

[horo, 2014-05-09 10:22:00]

https://codereview.chromium.org/270873005/diff/1/Source/bindings/v8/WorkerScr...
File Source/bindings/v8/WorkerScriptController.cpp (right):

https://codereview.chromium.org/270873005/diff/1/Source/bindings/v8/WorkerScr...
Source/bindings/v8/WorkerScriptController.cpp:158:
ASSERT(isContextInitialized());
On 2014/05/09 10:03:22, haraken wrote:
> 
> I think it's OK to call initializeContext from WorkerThread.cpp, but I don't
> think it's OK to assume that context is initialized when evaluate() is called.
> 
> WorkerThread is not the only caller of evaluate(), so it's (probably
> potentially) possible that other callers call evaluate() without initializing
> context.
> 
> How about:
> 
> - Keep the name "initializeContextIfNeeded" as is.
> - Keep WorkerScriptController::evaluate() as is.
> - Call initializeContextIfNeeded() from WorkerThread.cpp.
> 
> ?

That sounds reasonable.
Done.

[haraken, 2014-05-09 13:57:35]

Sorry for being late. LGTM.

[horo, 2014-05-12 04:52:31]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-05-12 04:52:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/horo@chromium.org/270873005/60001

[commit-bot: I haz the power, 2014-05-12 06:15:26]

Change committed as 173851