Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 270873004: New binary files for app window frame buttons. (Closed)

Created:
6 years, 7 months ago by benwells
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

New binary files for app window frame buttons. These are bitmaps to use in dark colored frames, for https://codereview.chromium.org/274013002. This change also moves the buttons currently in use from win/ to common/ as they are also used on Linux. BUG=339558 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
A + chrome/app/theme/default_100_percent/common/app_window_close.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_close_active.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_close_hover.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_close_unfocused.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_maximize.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_maximize_active.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_maximize_disabled.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_maximize_hover.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/app_window_maximize_light.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_minimize.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_minimize_active.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_minimize_hover.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/app_window_minimize_light.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_restore.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_restore_active.png View Binary file 0 comments Download
A + chrome/app/theme/default_100_percent/common/app_window_restore_hover.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/app_window_restore_light.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_close.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_close_active.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_close_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_close_unfocused.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_maximize.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_maximize_active.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_maximize_disabled.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_maximize_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_minimize.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_minimize_active.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_minimize_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_restore.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_restore_active.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/app_window_restore_hover.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +17 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
benwells
New images crushed with the optimize script and -o2.
6 years, 7 months ago (2014-05-09 09:07:03 UTC) #1
oshima
lgtm
6 years, 7 months ago (2014-05-09 09:20:48 UTC) #2
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 7 months ago (2014-05-09 11:50:32 UTC) #3
benwells
The CQ bit was unchecked by benwells@chromium.org
6 years, 7 months ago (2014-05-09 11:52:22 UTC) #4
benwells
6 years, 7 months ago (2014-05-10 01:56:18 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as r269477 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698