chrome/utility/media_galleries/media_metadata_parser.cc - Issue 270873003: Media: Add thumbnail extraction to AudioVideoMetadataExtractor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/media_galleries/media_metadata_parser.cc

Issue 270873003: Media: Add thumbnail extraction to AudioVideoMetadataExtractor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/utility/media_galleries/media_metadata_parser.cc

diff --git a/chrome/utility/media_galleries/media_metadata_parser.cc b/chrome/utility/media_galleries/media_metadata_parser.cc

index 9475bb877e683606002314e3ee2d203458678105..906ff45142e5eab6875f3c2831b6e0dcae60dda7 100644

--- a/chrome/utility/media_galleries/media_metadata_parser.cc

+++ b/chrome/utility/media_galleries/media_metadata_parser.cc

@@ -56,7 +56,8 @@ scoped_ptr<MediaMetadataParser::MediaMetadata> ParseAudioVideoMetadata(

DCHECK(metadata.get());

media::AudioVideoMetadataExtractor extractor;

- if (!extractor.Extract(source))

+ // TODO(tommycli): Add attached picture extraction.

+ if (!extractor.Extract(source, false /* extract_attached_pics */))

return metadata.Pass();

if (extractor.duration() >= 0)