Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 270873003: Media: Add thumbnail extraction to AudioVideoMetadataExtractor. (Closed)

Created:
6 years, 7 months ago by tommycli
Modified:
6 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Media: Add thumbnail extraction to AudioVideoMetadataExtractor. Spinoff of patch https://codereview.chromium.org/250143002/ For trivial change in chrome/utility/media_galleries/media_metadata_parser.cc: TBR=vandebo BUG=304290 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269588

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -11 lines) Patch
M chrome/utility/media_galleries/media_metadata_parser.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M media/base/audio_video_metadata_extractor.h View 3 chunks +7 lines, -1 line 0 comments Download
M media/base/audio_video_metadata_extractor.cc View 4 chunks +24 lines, -2 lines 0 comments Download
M media/base/audio_video_metadata_extractor_unittest.cc View 1 2 9 chunks +28 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
tommycli
dalecurtis: PTAL This is a spinoff of patch https://codereview.chromium.org/250143002/, which was getting too gigantic.
6 years, 7 months ago (2014-05-08 20:50:03 UTC) #1
DaleCurtis
lgtm https://codereview.chromium.org/270873003/diff/20001/media/base/audio_video_metadata_extractor_unittest.cc File media/base/audio_video_metadata_extractor_unittest.cc (right): https://codereview.chromium.org/270873003/diff/20001/media/base/audio_video_metadata_extractor_unittest.cc#newcode197 media/base/audio_video_metadata_extractor_unittest.cc:197: EXPECT_EQ("\x89PNG\r\n\x1a\n", You can use base::MD5 or base::Sha1 to ...
6 years, 7 months ago (2014-05-08 23:02:24 UTC) #2
tommycli
https://codereview.chromium.org/270873003/diff/20001/media/base/audio_video_metadata_extractor_unittest.cc File media/base/audio_video_metadata_extractor_unittest.cc (right): https://codereview.chromium.org/270873003/diff/20001/media/base/audio_video_metadata_extractor_unittest.cc#newcode197 media/base/audio_video_metadata_extractor_unittest.cc:197: EXPECT_EQ("\x89PNG\r\n\x1a\n", On 2014/05/08 23:02:25, DaleCurtis wrote: > You can ...
6 years, 7 months ago (2014-05-08 23:20:42 UTC) #3
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 7 months ago (2014-05-08 23:22:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/270873003/40001
6 years, 7 months ago (2014-05-08 23:27:18 UTC) #5
tommycli
The CQ bit was unchecked by tommycli@chromium.org
6 years, 7 months ago (2014-05-09 15:18:26 UTC) #6
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 7 months ago (2014-05-09 15:18:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/270873003/40001
6 years, 7 months ago (2014-05-09 15:22:39 UTC) #8
tommycli
The CQ bit was unchecked by tommycli@chromium.org
6 years, 7 months ago (2014-05-09 22:19:12 UTC) #9
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 7 months ago (2014-05-09 22:19:12 UTC) #10
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 7 months ago (2014-05-09 22:53:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/270873003/40001
6 years, 7 months ago (2014-05-09 22:56:57 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 18:14:25 UTC) #13
Message was sent while issue was closed.
Change committed as 269588

Powered by Google App Engine
This is Rietveld 408576698