Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 270873002: Extract GCMClient data types into separate gcm_types.h (Closed)

Created:
6 years, 7 months ago by johnme
Modified:
6 years ago
Reviewers:
jianli
CC:
chromium-reviews, tim+watch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org, haitaol+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Extract GCMClient data types into separate gcm_types.h This patch moves Result, MessageData, OutgoingMessage, IncomingMessage and SendErrorDetails out of GCMClient and into a new gcm_types.h file that can be included in cases where GCMClient is not being used, but it it still desirable to communicate using the same data types, for example the upcoming Android GCM implementation will share these. BUG=350384

Patch Set 1 #

Patch Set 2 : Reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -396 lines) Patch
M chrome/browser/extensions/api/gcm/gcm_api.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/gcm/gcm_api.cc View 7 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/extensions/api/gcm/gcm_apitest.cc View 5 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/invalidation/gcm_invalidation_bridge.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/invalidation/gcm_invalidation_bridge.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/invalidation/gcm_invalidation_bridge_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/services/gcm/default_gcm_app_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/services/gcm/default_gcm_app_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/services/gcm/fake_gcm_profile_service.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/services/gcm/fake_gcm_profile_service.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/services/gcm/gcm_app_handler.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/services/gcm/gcm_client_mock.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/services/gcm/gcm_service.h View 5 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/services/gcm/gcm_service.cc View 21 chunks +33 lines, -33 lines 0 comments Download
M chrome/browser/services/gcm/gcm_service_unittest.cc View 54 chunks +96 lines, -96 lines 0 comments Download
M google_apis/gcm/gcm.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/gcm/gcm_client.h View 3 chunks +2 lines, -56 lines 0 comments Download
M google_apis/gcm/gcm_client.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 7 chunks +21 lines, -18 lines 0 comments Download
M google_apis/gcm/gcm_client_impl_unittest.cc View 14 chunks +22 lines, -22 lines 0 comments Download
A google_apis/gcm/public/gcm_types.h View 1 chunk +72 lines, -0 lines 0 comments Download
A google_apis/gcm/public/gcm_types.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M sync/notifier/gcm_network_channel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/notifier/gcm_network_channel.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M sync/notifier/gcm_network_channel_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/notifier/gcm_network_channel_unittest.cc View 8 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
johnme
Hey Jian, is this the kind of thing you meant on https://codereview.chromium.org/278493002#msg4 by "those types ...
6 years, 7 months ago (2014-05-08 15:14:06 UTC) #1
johnme
6 years ago (2014-11-25 14:31:16 UTC) #2
Message was sent while issue was closed.
Abandoned - no longer necessary now that GCMClient.h moved into the
components/gcm_driver

Powered by Google App Engine
This is Rietveld 408576698