Expand FrameSeleciton::isRange() to increase chances of hoisting update layout

third_party/WebKit/Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 298 matching lines @@
   Node* node = body->firstChild();
   if (!isHTMLImageElement(node))
     return 0;
   return toHTMLImageElement(node);
 }
 
 bool Editor::canCopy() const {
   if (imageElementFromImageDocument(frame().document()))
     return true;
   FrameSelection& selection = frame().selection();
-  return selection.isRange() && !selection.isInPasswordField();
+  return selection.computeVisibleSelectionInDOMTreeDeprecated().isRange() &&
+         !selection.isInPasswordField();
 }
 
 bool Editor::canPaste() const {
   return canEdit();
 }
 
 bool Editor::canDelete() const {
   FrameSelection& selection = frame().selection();
-  return selection.isRange() && selection.rootEditableElement();
+  return selection.computeVisibleSelectionInDOMTreeDeprecated().isRange() &&
+         selection.rootEditableElement();
 }
 
 bool Editor::smartInsertDeleteEnabled() const {
   if (Settings* settings = frame().settings())
     return settings->getSmartInsertDeleteEnabled();
   return false;
 }
 
 bool Editor::canSmartCopyOrDelete() const {
   return smartInsertDeleteEnabled() &&
          frame().selection().granularity() == WordGranularity;
 }
 
 bool Editor::isSelectTrailingWhitespaceEnabled() const {
   if (Settings* settings = frame().settings())
     return settings->getSelectTrailingWhitespaceEnabled();
   return false;
 }
 
 bool Editor::deleteWithDirection(DeleteDirection direction,
                                  TextGranularity granularity,
                                  bool killRing,
                                  bool isTypingAction) {
   if (!canEdit())
     return false;
 
   EditingState editingState;
-  if (frame().selection().isRange()) {
+  if (frame()
+          .selection()
+          .computeVisibleSelectionInDOMTreeDeprecated()
+          .isRange()) {
     if (isTypingAction) {
       DCHECK(frame().document());
       TypingCommand::deleteKeyPressed(
           *frame().document(),
           canSmartCopyOrDelete() ? TypingCommand::SmartDelete : 0, granularity);
       revealSelectionAfterEditingOperation();
     } else {
       if (killRing)
         addToKillRing(selectedRange());
       deleteSelectionWithSmartDelete(
@@ skipping 1368 matching lines @@
 
 DEFINE_TRACE(Editor) {
   visitor->trace(m_frame);
   visitor->trace(m_lastEditCommand);
   visitor->trace(m_undoStack);
   visitor->trace(m_mark);
   visitor->trace(m_typingStyle);
 }
 
 }  // namespace blink