Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2708703002: Capture const/final/var keyword in AstBuilder.endTopLevelFields. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Capture const/final/var keyword in AstBuilder.endTopLevelFields. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/eabf574d7b1b59dac415b40bc5f16dbb6f70bcd7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M pkg/analyzer/test/generated/parser_test.dart View 4 chunks +16 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 10 months ago (2017-02-20 15:27:44 UTC) #2
ahe
lgtm
3 years, 10 months ago (2017-02-20 15:32:13 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as eabf574d7b1b59dac415b40bc5f16dbb6f70bcd7 (presubmit successful).
3 years, 10 months ago (2017-02-20 15:38:11 UTC) #5
scheglov
3 years, 10 months ago (2017-02-20 18:29:51 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698