Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2708653002: [Android NTP] Allow overlapping snap scroll regions. (Closed)
Patch Set: test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index 1994220097dc7f42a9727d9eac12361fbee15b48..1f32c026c8bb3c14bd36fe6db6b7ead1935a0bc9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -439,8 +439,7 @@ public class NewTabPageView
assert mPendingSnapScroll;
mPendingSnapScroll = false;
- mRecyclerView.snapScroll(mSearchBoxView,
- mRecyclerView.computeVerticalScrollOffset(), getHeight());
+ mRecyclerView.snapScroll(mSearchBoxView, getHeight());
}
};
@@ -765,8 +764,7 @@ public class NewTabPageView
mRecyclerView.updatePeekingCardAndHeader();
// The positioning of elements may have been changed (since the elements expand to fill
// the available vertical space), so adjust the scroll.
- mRecyclerView.snapScroll(mSearchBoxView,
- mRecyclerView.computeVerticalScrollOffset(), getHeight());
+ mRecyclerView.snapScroll(mSearchBoxView, getHeight());
}
/**

Powered by Google App Engine
This is Rietveld 408576698