Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 270863006: Pepper: Miscellaneous trusted plugin cleanup. (Closed)

Created:
6 years, 7 months ago by teravest
Modified:
6 years, 7 months ago
Reviewers:
bbudge
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Visibility:
Public.

Description

Pepper: Miscellaneous trusted plugin cleanup. This does some small cleanup of a bunch of little things without any logic changes. BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270010

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -74 lines) Patch
M components/nacl/renderer/ppb_nacl_private_impl.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 3 chunks +1 line, -4 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 3 chunks +1 line, -3 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 1 4 chunks +9 lines, -36 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
teravest
6 years, 7 months ago (2014-05-12 17:22:23 UTC) #1
teravest
6 years, 7 months ago (2014-05-12 17:22:24 UTC) #2
bbudge
lgtm
6 years, 7 months ago (2014-05-12 17:48:52 UTC) #3
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 7 months ago (2014-05-12 17:49:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/270863006/40001
6 years, 7 months ago (2014-05-12 17:50:12 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 23:24:26 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 04:14:20 UTC) #7
Message was sent while issue was closed.
Change committed as 270010

Powered by Google App Engine
This is Rietveld 408576698