ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm - Issue 2708623002: Add an ID to the ContentSuggestion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm

Issue 2708623002: Add an ID to the ContentSuggestion (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/content_suggestions/content_suggestion_id.mm ('K') | « ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm

diff --git a/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm b/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm

index 6e2c9a374327468ed7525c3cf60551133f5886b5..d66ca531ee895f0b69270f2665afd60619d393df 100644

--- a/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm

+++ b/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm

@@ -9,6 +9,7 @@

#import "ios/chrome/browser/ui/collection_view/collection_view_controller.h"

#import "ios/chrome/browser/ui/collection_view/collection_view_model.h"

#import "ios/chrome/browser/ui/content_suggestions/content_suggestion.h"

+#import "ios/chrome/browser/ui/content_suggestions/content_suggestion_id.h"

#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h"

#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h"

#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h"

@@ -184,7 +185,8 @@ SectionIdentifier SectionIdentifierForInfo(

NSArray<ContentSuggestion*>* suggestions = [self.dataSource allSuggestions];

for (ContentSuggestion* suggestion in suggestions) {

- NSInteger sectionIdentifier = [self addSectionIfNeeded:suggestion.section];

+ NSInteger sectionIdentifier =

+ [self addSectionIfNeeded:suggestion.suggestionID.sectionInfo];

ContentSuggestionsArticleItem* articleItem =

[[ContentSuggestionsArticleItem alloc]

initWithType:ItemTypeForContentSuggestionType(suggestion.type)

@@ -192,6 +194,7 @@ SectionIdentifier SectionIdentifierForInfo(

subtitle:suggestion.text

image:suggestion.image

url:suggestion.url];

+ articleItem.suggestionID = suggestion.suggestionID;

[model addItem:articleItem toSectionWithIdentifier:sectionIdentifier];

}