Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 2708613002: Add EventForwarder for routing touch events (Closed)
Patch Set: EventForwarder... Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index e036fb8b1664ecae254d67f2594a5dc420a12fc7..cd96d20ba4caf0245cd903275f296a1a728cb266 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -162,17 +162,6 @@ int ToGestureEventType(WebInputEvent::Type type) {
}
}
-void RecordToolTypeForActionDown(MotionEventAndroid& event) {
- MotionEventAndroid::Action action = event.GetAction();
- if (action == MotionEventAndroid::ACTION_DOWN ||
- action == MotionEventAndroid::ACTION_POINTER_DOWN ||
- action == MotionEventAndroid::ACTION_BUTTON_PRESS) {
- UMA_HISTOGRAM_ENUMERATION("Event.AndroidActionDown.ToolType",
- event.GetToolType(0),
- MotionEventAndroid::TOOL_TYPE_LAST + 1);
- }
-}
-
} // namespace
// Enables a callback when the underlying WebContents is destroyed, to enable
@@ -876,127 +865,6 @@ void ContentViewCoreImpl::SendOrientationChangeEvent(
}
}
-jboolean ContentViewCoreImpl::OnTouchEvent(
- JNIEnv* env,
- const JavaParamRef<jobject>& obj,
- const JavaParamRef<jobject>& motion_event,
- jlong time_ms,
- jint android_action,
- jint pointer_count,
- jint history_size,
- jint action_index,
- jfloat pos_x_0,
- jfloat pos_y_0,
- jfloat pos_x_1,
- jfloat pos_y_1,
- jint pointer_id_0,
- jint pointer_id_1,
- jfloat touch_major_0,
- jfloat touch_major_1,
- jfloat touch_minor_0,
- jfloat touch_minor_1,
- jfloat orientation_0,
- jfloat orientation_1,
- jfloat tilt_0,
- jfloat tilt_1,
- jfloat raw_pos_x,
- jfloat raw_pos_y,
- jint android_tool_type_0,
- jint android_tool_type_1,
- jint android_button_state,
- jint android_meta_state,
- jboolean is_touch_handle_event) {
- RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
- // Avoid synthesizing a touch event if it cannot be forwarded.
- if (!rwhv)
- return false;
-
- MotionEventAndroid::Pointer pointer0(pointer_id_0,
- pos_x_0,
- pos_y_0,
- touch_major_0,
- touch_minor_0,
- orientation_0,
- tilt_0,
- android_tool_type_0);
- MotionEventAndroid::Pointer pointer1(pointer_id_1,
- pos_x_1,
- pos_y_1,
- touch_major_1,
- touch_minor_1,
- orientation_1,
- tilt_1,
- android_tool_type_1);
- MotionEventAndroid event(1.f / dpi_scale(),
- env,
- motion_event,
- time_ms,
- android_action,
- pointer_count,
- history_size,
- action_index,
- android_button_state,
- android_meta_state,
- raw_pos_x - pos_x_0,
- raw_pos_y - pos_y_0,
- &pointer0,
- &pointer1);
-
- RecordToolTypeForActionDown(event);
-
- return is_touch_handle_event ? rwhv->OnTouchHandleEvent(event)
- : rwhv->OnTouchEvent(event);
-}
-
-jboolean ContentViewCoreImpl::SendMouseEvent(JNIEnv* env,
- const JavaParamRef<jobject>& obj,
- jlong time_ms,
- jint android_action,
- jfloat x,
- jfloat y,
- jint pointer_id,
- jfloat pressure,
- jfloat orientation,
- jfloat tilt,
- jint android_action_button,
- jint android_button_state,
- jint android_meta_state,
- jint android_tool_type) {
- RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
- if (!rwhv)
- return false;
-
- // Construct a motion_event object minimally, only to convert the raw
- // parameters to ui::MotionEvent values. Since we used only the cached values
- // at index=0, it is okay to even pass a null event to the constructor.
- MotionEventAndroid::Pointer pointer0(
- pointer_id, x, y, 0.0f /* touch_major */, 0.0f /* touch_minor */,
- orientation, tilt, android_tool_type);
-
- MotionEventAndroid motion_event(1.f / dpi_scale(),
- env,
- nullptr /* event */,
- time_ms,
- android_action,
- 1 /* pointer_count */,
- 0 /* history_size */,
- 0 /* action_index */,
- android_button_state,
- android_meta_state,
- 0 /* raw_offset_x_pixels */,
- 0 /* raw_offset_y_pixels */,
- &pointer0,
- nullptr);
-
- RecordToolTypeForActionDown(motion_event);
-
- // Note: This relies on identical button enum values in MotionEvent and
- // MotionEventAndroid.
- rwhv->SendMouseEvent(motion_event, android_action_button);
-
- return true;
-}
-
jboolean ContentViewCoreImpl::SendMouseWheelEvent(
JNIEnv* env,
const JavaParamRef<jobject>& obj,
@@ -1220,6 +1088,15 @@ void ContentViewCoreImpl::SetMultiTouchZoomSupportEnabled(
rwhv->SetMultiTouchZoomSupportEnabled(enabled);
}
+void ContentViewCoreImpl::OnTouchDown(
+ const base::android::ScopedJavaLocalRef<jobject>& event) {
+ JNIEnv* env = AttachCurrentThread();
+ ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
+ if (obj.is_null())
+ return;
+ Java_ContentViewCore_onTouchDown(env, obj, event);
+}
+
void ContentViewCoreImpl::SetAllowJavascriptInterfacesInspection(
JNIEnv* env,
const JavaParamRef<jobject>& obj,
@@ -1506,6 +1383,7 @@ jlong Init(JNIEnv* env,
"A ContentViewCoreImpl should be created with a valid WebContents.";
ui::ViewAndroid* view_android = web_contents->GetView()->GetNativeView();
view_android->SetDelegate(jview_android_delegate);
+ view_android->SetLayout(ui::ViewAndroid::LayoutParams::MatchParent());
ui::WindowAndroid* window_android =
reinterpret_cast<ui::WindowAndroid*>(jwindow_android);
« no previous file with comments | « content/browser/android/content_view_core_impl.h ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698