Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: src/zone/zone-allocator.h

Issue 2708593004: Define illegal zone_allocator constructor only for MSVS (Closed)
Patch Set: Use V8_CC_MSVC instead of V8_OS_WIN Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ZONE_ZONE_ALLOCATOR_H_ 5 #ifndef V8_ZONE_ZONE_ALLOCATOR_H_
6 #define V8_ZONE_ZONE_ALLOCATOR_H_ 6 #define V8_ZONE_ZONE_ALLOCATOR_H_
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/zone/zone.h" 9 #include "src/zone/zone.h"
10 10
11 namespace v8 { 11 namespace v8 {
12 namespace internal { 12 namespace internal {
13 13
14 template <typename T> 14 template <typename T>
15 class zone_allocator { 15 class zone_allocator {
16 public: 16 public:
17 typedef T* pointer; 17 typedef T* pointer;
18 typedef const T* const_pointer; 18 typedef const T* const_pointer;
19 typedef T& reference; 19 typedef T& reference;
20 typedef const T& const_reference; 20 typedef const T& const_reference;
21 typedef T value_type; 21 typedef T value_type;
22 typedef size_t size_type; 22 typedef size_t size_type;
23 typedef ptrdiff_t difference_type; 23 typedef ptrdiff_t difference_type;
24 template <class O> 24 template <class O>
25 struct rebind { 25 struct rebind {
26 typedef zone_allocator<O> other; 26 typedef zone_allocator<O> other;
27 }; 27 };
28 28
29 // TODO(bbudge) Remove when V8 updates to MSVS 2015. See crbug.com/603131. 29 #ifdef V8_CC_MSVC
30 // MSVS unfortunately requires the default constructor to be defined.
30 zone_allocator() : zone_(nullptr) { UNREACHABLE(); } 31 zone_allocator() : zone_(nullptr) { UNREACHABLE(); }
32 #endif
31 explicit zone_allocator(Zone* zone) throw() : zone_(zone) {} 33 explicit zone_allocator(Zone* zone) throw() : zone_(zone) {}
32 explicit zone_allocator(const zone_allocator& other) throw() 34 explicit zone_allocator(const zone_allocator& other) throw()
33 : zone_(other.zone_) {} 35 : zone_(other.zone_) {}
34 template <typename U> 36 template <typename U>
35 zone_allocator(const zone_allocator<U>& other) throw() : zone_(other.zone_) {} 37 zone_allocator(const zone_allocator<U>& other) throw() : zone_(other.zone_) {}
36 template <typename U> 38 template <typename U>
37 friend class zone_allocator; 39 friend class zone_allocator;
38 40
39 pointer address(reference x) const { return &x; } 41 pointer address(reference x) const { return &x; }
40 const_pointer address(const_reference x) const { return &x; } 42 const_pointer address(const_reference x) const { return &x; }
(...skipping 30 matching lines...) Expand all
71 private: 73 private:
72 Zone* zone_; 74 Zone* zone_;
73 }; 75 };
74 76
75 typedef zone_allocator<bool> ZoneBoolAllocator; 77 typedef zone_allocator<bool> ZoneBoolAllocator;
76 typedef zone_allocator<int> ZoneIntAllocator; 78 typedef zone_allocator<int> ZoneIntAllocator;
77 } // namespace internal 79 } // namespace internal
78 } // namespace v8 80 } // namespace v8
79 81
80 #endif // V8_ZONE_ZONE_ALLOCATOR_H_ 82 #endif // V8_ZONE_ZONE_ALLOCATOR_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698