Advance picture id of keyframe if the stream has been continuous without a new keyframe for a while.

Advance picture id of keyframe if the stream has been continuous without a new keyframe for a while.

BUG=webrtc:5514
Review-Url: https://codereview.webrtc.org/2708593003
Cr-Commit-Position: refs/heads/master@{#16725}
Committed: https://chromium.googlesource.com/external/webrtc/+/41bb792ce47ead4e137d20aa4d87a30683992ac7

[philipel, 2017-02-20 12:20:43]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org

[philipel, 2017-02-20 12:29:03]

philipel@webrtc.org changed reviewers:
+ terelius@webrtc.org
- stefan@webrtc.org

[philipel, 2017-02-20 12:29:43]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org
- terelius@webrtc.org

[terelius, 2017-02-20 13:19:47]

terelius@webrtc.org changed reviewers:
+ terelius@webrtc.org

[terelius, 2017-02-20 13:19:48]

https://codereview.webrtc.org/2708593003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc (right):

https://codereview.webrtc.org/2708593003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc:304: uint16_t
sn = Rand();
With a random sequence number you have no way of knowing if or when the sequence
number wraps, right?

[philipel, 2017-02-20 13:26:43]

https://codereview.webrtc.org/2708593003/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc (right):

https://codereview.webrtc.org/2708593003/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc:304: uint16_t
sn = Rand();
On 2017/02/20 13:19:48, terelius wrote:
> With a random sequence number you have no way of knowing if or when the
sequence
> number wraps, right?

That is true, but the problem only occurs when the sequence number of the last
packet of a frame is further ahead than <keyframe sequence number + 2^15>. If
the actual sequence number has wrapped or not does not matter in this case.

[terelius, 2017-02-20 13:48:18]

lgtm

[philipel, 2017-02-20 13:49:18]

The CQ bit was checked by philipel@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 13:49:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[stefan-webrtc, 2017-02-20 13:53:20]

lgtm

[commit-bot: I haz the power, 2017-02-20 15:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 15:39:29]

Dry run: This issue passed the CQ dry run.

[philipel, 2017-02-20 15:50:44]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2017-02-20 15:50:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-20 15:53:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487605844015970,
"parent_rev": "b2f0800a61d47bdd8b40eb7facebe6a4796313ef", "commit_rev":
"41bb792ce47ead4e137d20aa4d87a30683992ac7"}

[commit-bot: I haz the power, 2017-02-20 15:53:25]

Description was changed from

==========
Advance picture id of keyframe if the stream has been continuous without a new
keyframe for a while.

BUG=webrtc:5514
==========

to

==========
Advance picture id of keyframe if the stream has been continuous without a new
keyframe for a while.

BUG=webrtc:5514

Review-Url: https://codereview.webrtc.org/2708593003
Cr-Commit-Position: refs/heads/master@{#16725}
Committed:
https://chromium.googlesource.com/external/webrtc/+/41bb792ce47ead4e137d20aa4...
==========

[commit-bot: I haz the power, 2017-02-20 15:53:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/41bb792ce47ead4e137d20aa4...