Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chromeos/dbus/debug_daemon_client.cc

Issue 270853002: Use base::File for DebugDaemonClient::GetDebugLogs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/debug_daemon_client.cc
diff --git a/chromeos/dbus/debug_daemon_client.cc b/chromeos/dbus/debug_daemon_client.cc
index 8a8804ff258fcdca35dfea96b3862f24960b650e..b73ccaa246f79d17dc3f4c6aad6fb8d38c647116 100644
--- a/chromeos/dbus/debug_daemon_client.cc
+++ b/chromeos/dbus/debug_daemon_client.cc
@@ -12,10 +12,10 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/callback.h"
+#include "base/files/file_path.h"
#include "base/location.h"
#include "base/memory/ref_counted_memory.h"
#include "base/message_loop/message_loop.h"
-#include "base/platform_file.h"
#include "base/posix/eintr_wrapper.h"
#include "base/strings/string_util.h"
#include "base/task_runner_util.h"
@@ -46,10 +46,11 @@ class DebugDaemonClientImpl : public DebugDaemonClient {
virtual ~DebugDaemonClientImpl() {}
// DebugDaemonClient override.
- virtual void GetDebugLogs(base::PlatformFile file,
+ virtual void GetDebugLogs(base::File file,
const GetDebugLogsCallback& callback) OVERRIDE {
- dbus::FileDescriptor* file_descriptor = new dbus::FileDescriptor(file);
+ dbus::FileDescriptor* file_descriptor = new dbus::FileDescriptor;
+ file_descriptor->PutValue(file.TakePlatformFile());
// Punt descriptor validity check to a worker thread; on return we'll
// issue the D-Bus request to stop tracing and collect results.
base::WorkerPool::PostTaskAndReply(

Powered by Google App Engine
This is Rietveld 408576698