Reporting: Implement cache.

net/reporting/reporting_cache_unittest.cc

Index: net/reporting/reporting_cache_unittest.cc
diff --git a/net/reporting/reporting_cache_unittest.cc b/net/reporting/reporting_cache_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2e259b4a866bd962b75f2dafe4d07366d9dbfeeb
--- /dev/null
+++ b/net/reporting/reporting_cache_unittest.cc
@@ -0,0 +1,253 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/reporting/reporting_cache.h"
+
+#include <string>
+
+#include "base/memory/ptr_util.h"
+#include "base/time/time.h"
+#include "base/values.h"
+#include "net/reporting/reporting_client.h"
+#include "net/reporting/reporting_report.h"
+#include "net/reporting/reporting_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
+#include "url/origin.h"
+
+namespace net {
+namespace {
+
+class ReportingCacheTest : public ::testing::Test {
+ protected:
+  const GURL kUrl1 = GURL("https://origin1/path");
+  const url::Origin kOrigin1 = url::Origin(GURL("https://origin1/"));
+  const url::Origin kOrigin2 = url::Origin(GURL("https://origin2/"));
+  const GURL kEndpoint1 = GURL("https://endpoint1/");
+  const GURL kEndpoint2 = GURL("https://endpoint2/");
+  const std::string kGroup1 = "group1";
+  const std::string kGroup2 = "group2";
+  const std::string kType = "default";
+  const base::TimeTicks kNow = base::TimeTicks::Now();
+  const base::TimeTicks kExpires1 = kNow + base::TimeDelta::FromDays(7);
+  const base::TimeTicks kExpires2 = kExpires1 + base::TimeDelta::FromDays(7);

[jkarlin, 2017/03/23 15:05:37]

The above members need _ suffixes.

[Julia Tuttle, 2017/03/23 19:24:04]

Done.

+
+  ReportingCache cache_;
+};
+
+TEST_F(ReportingCacheTest, Reports) {
+  std::vector<const ReportingReport*> reports;
+  cache_.GetReports(&reports);
+  EXPECT_TRUE(reports.empty());
+
+  cache_.AddReport(kUrl1, kGroup1, kType,
+                   base::MakeUnique<base::DictionaryValue>(), kNow, 0);
+
+  cache_.GetReports(&reports);
+  ASSERT_EQ(1u, reports.size());
+  const ReportingReport* report = reports[0];
+  ASSERT_TRUE(report);
+  EXPECT_EQ(kUrl1, report->url);
+  EXPECT_EQ(kGroup1, report->group);
+  EXPECT_EQ(kType, report->type);
+  // TODO(juliatuttle): Check body?
+  EXPECT_EQ(kNow, report->queued);
+  EXPECT_EQ(0, report->attempts);
+  EXPECT_FALSE(cache_.IsReportPendingForTesting(report));
+  EXPECT_FALSE(cache_.IsReportDoomedForTesting(report));
+
+  cache_.IncrementReportsAttempts(reports);
+
+  cache_.GetReports(&reports);
+  ASSERT_EQ(1u, reports.size());
+  report = reports[0];
+  ASSERT_TRUE(report);
+  EXPECT_EQ(1, report->attempts);
+
+  cache_.RemoveReports(reports);
+
+  cache_.GetReports(&reports);
+  EXPECT_TRUE(reports.empty());
+}
+
+TEST_F(ReportingCacheTest, RemoveAllReports) {
+  cache_.AddReport(kUrl1, kGroup1, kType,
+                   base::MakeUnique<base::DictionaryValue>(), kNow, 0);
+  cache_.AddReport(kUrl1, kGroup1, kType,
+                   base::MakeUnique<base::DictionaryValue>(), kNow, 0);
+
+  std::vector<const ReportingReport*> reports;
+  cache_.GetReports(&reports);
+  EXPECT_EQ(2u, reports.size());
+
+  cache_.RemoveAllReports();
+
+  cache_.GetReports(&reports);
+  EXPECT_TRUE(reports.empty());
+}
+
+TEST_F(ReportingCacheTest, RemovePendingReports) {
+  cache_.AddReport(kUrl1, kGroup1, kType,
+                   base::MakeUnique<base::DictionaryValue>(), kNow, 0);
+
+  std::vector<const ReportingReport*> reports;
+  cache_.GetReports(&reports);
+  ASSERT_EQ(1u, reports.size());
+  EXPECT_FALSE(cache_.IsReportPendingForTesting(reports[0]));
+  EXPECT_FALSE(cache_.IsReportDoomedForTesting(reports[0]));
+
+  cache_.SetReportsPending(reports);
+  EXPECT_TRUE(cache_.IsReportPendingForTesting(reports[0]));
+  EXPECT_FALSE(cache_.IsReportDoomedForTesting(reports[0]));
+
+  cache_.RemoveReports(reports);
+  EXPECT_TRUE(cache_.IsReportPendingForTesting(reports[0]));
+  EXPECT_TRUE(cache_.IsReportDoomedForTesting(reports[0]));
+
+  // After removing report, future calls to GetReports should not return it.
+  std::vector<const ReportingReport*> visible_reports;
+  cache_.GetReports(&visible_reports);
+  EXPECT_TRUE(visible_reports.empty());
+  EXPECT_EQ(1u, cache_.GetFullReportCountForTesting());
+
+  // After clearing pending flag, report should be deleted.
+  cache_.ClearReportsPending(reports);
+  EXPECT_EQ(0u, cache_.GetFullReportCountForTesting());
+}
+
+TEST_F(ReportingCacheTest, RemoveAllPendingReports) {
+  cache_.AddReport(kUrl1, kGroup1, kType,
+                   base::MakeUnique<base::DictionaryValue>(), kNow, 0);
+
+  std::vector<const ReportingReport*> reports;
+  cache_.GetReports(&reports);
+  ASSERT_EQ(1u, reports.size());
+  EXPECT_FALSE(cache_.IsReportPendingForTesting(reports[0]));
+  EXPECT_FALSE(cache_.IsReportDoomedForTesting(reports[0]));
+
+  cache_.SetReportsPending(reports);
+  EXPECT_TRUE(cache_.IsReportPendingForTesting(reports[0]));
+  EXPECT_FALSE(cache_.IsReportDoomedForTesting(reports[0]));
+
+  cache_.RemoveAllReports();
+  EXPECT_TRUE(cache_.IsReportPendingForTesting(reports[0]));
+  EXPECT_TRUE(cache_.IsReportDoomedForTesting(reports[0]));
+
+  // After removing report, future calls to GetReports should not return it.
+  std::vector<const ReportingReport*> visible_reports;
+  cache_.GetReports(&visible_reports);
+  EXPECT_TRUE(visible_reports.empty());
+  EXPECT_EQ(1u, cache_.GetFullReportCountForTesting());
+
+  // After clearing pending flag, report should be deleted.
+  cache_.ClearReportsPending(reports);
+  EXPECT_EQ(0u, cache_.GetFullReportCountForTesting());
+}
+
+TEST_F(ReportingCacheTest, Endpoints) {
+  cache_.SetClient(kOrigin1, kEndpoint1, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup1, kExpires1);
+
+  const ReportingClient* client =
+      FindClientInCache(&cache_, kOrigin1, kEndpoint1);
+  ASSERT_TRUE(client);
+  EXPECT_EQ(kOrigin1, client->origin);
+  EXPECT_EQ(kEndpoint1, client->endpoint);
+  EXPECT_EQ(ReportingClient::Subdomains::EXCLUDE, client->subdomains);
+  EXPECT_EQ(kGroup1, client->group);
+  EXPECT_EQ(kExpires1, client->expires);
+
+  // Replaces original configuration with new Subdomains, group, and expires
+  // values.
+  cache_.SetClient(kOrigin1, kEndpoint1, ReportingClient::Subdomains::INCLUDE,
+                   kGroup2, kExpires2);
+
+  client = FindClientInCache(&cache_, kOrigin1, kEndpoint1);
+  ASSERT_TRUE(client);
+  EXPECT_EQ(kOrigin1, client->origin);
+  EXPECT_EQ(kEndpoint1, client->endpoint);
+  EXPECT_EQ(ReportingClient::Subdomains::INCLUDE, client->subdomains);
+  EXPECT_EQ(kGroup2, client->group);
+  EXPECT_EQ(kExpires2, client->expires);
+
+  cache_.RemoveClients(std::vector<const ReportingClient*>{client});
+
+  client = FindClientInCache(&cache_, kOrigin1, kEndpoint1);
+  EXPECT_FALSE(client);
+}
+
+TEST_F(ReportingCacheTest, GetClientsForOriginAndGroup) {
+  cache_.SetClient(kOrigin1, kEndpoint1, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup1, kExpires1);
+  cache_.SetClient(kOrigin1, kEndpoint2, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup2, kExpires1);
+  cache_.SetClient(kOrigin2, kEndpoint1, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup1, kExpires1);
+
+  std::vector<const ReportingClient*> clients;
+  cache_.GetClientsForOriginAndGroup(kOrigin1, kGroup1, &clients);
+  ASSERT_EQ(1u, clients.size());
+  const ReportingClient* client = clients[0];
+  ASSERT_TRUE(client);
+  EXPECT_EQ(kOrigin1, client->origin);
+  EXPECT_EQ(kGroup1, client->group);
+}
+
+TEST_F(ReportingCacheTest, RemoveClientForOriginAndEndpoint) {
+  cache_.SetClient(kOrigin1, kEndpoint1, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup1, kExpires1);
+  cache_.SetClient(kOrigin1, kEndpoint2, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup2, kExpires1);
+  cache_.SetClient(kOrigin2, kEndpoint1, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup1, kExpires1);
+
+  cache_.RemoveClientForOriginAndEndpoint(kOrigin1, kEndpoint1);
+
+  std::vector<const ReportingClient*> clients;
+  cache_.GetClientsForOriginAndGroup(kOrigin1, kGroup1, &clients);
+  EXPECT_TRUE(clients.empty());
+
+  cache_.GetClientsForOriginAndGroup(kOrigin1, kGroup2, &clients);
+  EXPECT_EQ(1u, clients.size());
+
+  cache_.GetClientsForOriginAndGroup(kOrigin2, kGroup1, &clients);
+  EXPECT_EQ(1u, clients.size());
+}
+
+TEST_F(ReportingCacheTest, RemoveClientsForEndpoint) {
+  cache_.SetClient(kOrigin1, kEndpoint1, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup1, kExpires1);
+  cache_.SetClient(kOrigin1, kEndpoint2, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup2, kExpires1);
+  cache_.SetClient(kOrigin2, kEndpoint1, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup1, kExpires1);
+
+  cache_.RemoveClientsForEndpoint(kEndpoint1);
+
+  std::vector<const ReportingClient*> clients;
+  cache_.GetClientsForOriginAndGroup(kOrigin1, kGroup1, &clients);
+  EXPECT_TRUE(clients.empty());
+
+  cache_.GetClientsForOriginAndGroup(kOrigin1, kGroup2, &clients);
+  EXPECT_EQ(1u, clients.size());
+
+  cache_.GetClientsForOriginAndGroup(kOrigin2, kGroup1, &clients);
+  EXPECT_TRUE(clients.empty());
+}
+
+TEST_F(ReportingCacheTest, RemoveAllClients) {
+  cache_.SetClient(kOrigin1, kEndpoint1, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup1, kExpires1);
+  cache_.SetClient(kOrigin2, kEndpoint2, ReportingClient::Subdomains::EXCLUDE,
+                   kGroup1, kExpires1);
+
+  cache_.RemoveAllClients();
+
+  std::vector<const ReportingClient*> clients;
+  cache_.GetClients(&clients);
+  EXPECT_TRUE(clients.empty());
+}
+
+}  // namespace
+}  // namespace net