Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2708483002: cc: migrate usage of SetValue() to the one that takes TracedValue (Closed)

Created:
3 years, 10 months ago by tfarina
Modified:
3 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: migrate usage of SetValue() to the one that takes TracedValue According to the TODO in TracedValue::SetValue() the one that takes TracedValue is cheaper than the one that takes base::Value. BUG=495628 TEST=cc_unittests --gtest_filter=DisplayItemListTest.* R=danakj@chromium.org,primiano@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2708483002 Cr-Commit-Position: refs/heads/master@{#452729} Committed: https://chromium.googlesource.com/chromium/src/+/07a320f2cd9d3a7967a99d9d71ae70b99ccad6a6

Patch Set 1 #

Patch Set 2 : another try #

Patch Set 3 : single line change #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/playback/display_item_list.cc View 1 2 1 chunk +1 line, -1 line 4 comments Download

Messages

Total messages: 24 (14 generated)
tfarina
Please, take a look when you have a spare time.
3 years, 10 months ago (2017-02-19 22:22:59 UTC) #4
Primiano Tucci (use gerrit)
On 2017/02/19 at 22:22:59, tfarina wrote: > Please, take a look when you have a ...
3 years, 10 months ago (2017-02-22 12:29:40 UTC) #13
danakj
https://codereview.chromium.org/2708483002/diff/40001/cc/playback/display_item_list.cc File cc/playback/display_item_list.cc (left): https://codereview.chromium.org/2708483002/diff/40001/cc/playback/display_item_list.cc#oldcode220 cc/playback/display_item_list.cc:220: state->SetValue("layer_rect", MathUtil::AsValue(rtree_.GetBounds())); Does a ListValue end up as an ...
3 years, 10 months ago (2017-02-22 14:48:19 UTC) #14
tfarina
https://codereview.chromium.org/2708483002/diff/40001/cc/playback/display_item_list.cc File cc/playback/display_item_list.cc (left): https://codereview.chromium.org/2708483002/diff/40001/cc/playback/display_item_list.cc#oldcode220 cc/playback/display_item_list.cc:220: state->SetValue("layer_rect", MathUtil::AsValue(rtree_.GetBounds())); On 2017/02/22 14:48:19, danakj wrote: > Does ...
3 years, 10 months ago (2017-02-22 21:28:56 UTC) #15
danakj
https://codereview.chromium.org/2708483002/diff/40001/cc/playback/display_item_list.cc File cc/playback/display_item_list.cc (left): https://codereview.chromium.org/2708483002/diff/40001/cc/playback/display_item_list.cc#oldcode220 cc/playback/display_item_list.cc:220: state->SetValue("layer_rect", MathUtil::AsValue(rtree_.GetBounds())); On 2017/02/22 21:28:56, tfarina wrote: > On ...
3 years, 10 months ago (2017-02-22 21:31:10 UTC) #16
tfarina
On 2017/02/22 21:31:10, danakj wrote: > https://codereview.chromium.org/2708483002/diff/40001/cc/playback/display_item_list.cc > File cc/playback/display_item_list.cc (left): > > https://codereview.chromium.org/2708483002/diff/40001/cc/playback/display_item_list.cc#oldcode220 > ...
3 years, 10 months ago (2017-02-23 23:17:19 UTC) #17
Primiano Tucci (use gerrit)
> Primiano, could you ańswer Dana's questioning? I knew that this codereview looked easy but ...
3 years, 10 months ago (2017-02-23 23:26:09 UTC) #18
danakj
ok thanks! LGTM
3 years, 10 months ago (2017-02-23 23:30:03 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708483002/40001
3 years, 10 months ago (2017-02-24 01:37:10 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 03:10:02 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/07a320f2cd9d3a7967a99d9d71ae...

Powered by Google App Engine
This is Rietveld 408576698