third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp - Issue 2708403003: Implement canvas color space IDL format for 2D canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

Issue 2708403003: Implement canvas color space IDL format for 2D canvas (Closed)

Patch Set: Fixing layout test failures Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl ('K') | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl » ('j') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

index 882496e8254e4eb2432b4663661983de312b0dbd..b0e83170c6d953edb1f86a84d0eb6447724e94d6 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

@@ -967,9 +967,11 @@ WebLayer* CanvasRenderingContext2D::platformLayer() const {

}

void CanvasRenderingContext2D::getContextAttributes(

- Canvas2DContextAttributes& attrs) const {

- attrs.setAlpha(creationAttributes().alpha());

- attrs.setColorSpace(colorSpaceAsString());

+ CanvasRenderingContext2DSettings& settings) const {

+ settings.setAlpha(creationAttributes().alpha());

+ settings.setColorSpace(colorSpaceAsString());

+ settings.setPixelFormat(pixelFormatAsString());

+ settings.setLinearPixelMath(linearPixelMath());

}

void CanvasRenderingContext2D::drawFocusIfNeeded(Element* element) {