Experimental: restore the test at the bottom of for and while loops....

Experimental: restore the test at the bottom of for and while loops.
In order to satisfy the requirement that a virtual frame has to reach
the body when we compile it, the test is duplicated and appears at
both the top and bottom of the loop.


Committed: http://code.google.com/p/v8/source/detail?r=1344

[Kasper Lund, 2009-02-24 08:52:55]

LGTM. I'm happy with tackling any considerable code size increase later.

http://codereview.chromium.org/27084/diff/1002/3
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/27084/diff/1002/3#newcode2262
Line 2262: } else if (info == ALWAYS_FALSE) {
I actually preferred to have this as a separate check before the "real"
compilation of the condition. Having a break "hidden" inside here seems a bit
complicated, so I'd rather have it at the beginning of the switch case.

http://codereview.chromium.org/27084/diff/1002/3#newcode2350
Line 2350: break;
Same here. Move ALWAYS_FALSE check to beginning of switch case?

[Kevin Millikin (Chromium), 2009-02-24 08:56:32]

http://codereview.chromium.org/27084/diff/1002/3
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/27084/diff/1002/3#newcode2262
Line 2262: } else if (info == ALWAYS_FALSE) {
On 2009/02/24 08:52:55, Kasper Lund wrote:
> I actually preferred to have this as a separate check before the "real"
> compilation of the condition. Having a break "hidden" inside here seems a bit
> complicated, so I'd rather have it at the beginning of the switch case.

Easily done.

[William Hesse, 2009-02-24 09:14:41]

LGTM.