Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 27084: Experimental: restore the test at the bottom of for and while loops.... (Closed)

Created:
11 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Experimental: restore the test at the bottom of for and while loops. In order to satisfy the requirement that a virtual frame has to reach the body when we compile it, the test is duplicated and appears at both the top and bottom of the loop. Committed: http://code.google.com/p/v8/source/detail?r=1344

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -76 lines) Patch
M src/codegen-ia32.cc View 1 2 chunks +133 lines, -76 lines 3 comments Download

Messages

Total messages: 4 (0 generated)
Kevin Millikin (Chromium)
11 years, 10 months ago (2009-02-24 08:32:37 UTC) #1
Kasper Lund
LGTM. I'm happy with tackling any considerable code size increase later. http://codereview.chromium.org/27084/diff/1002/3 File src/codegen-ia32.cc (right): ...
11 years, 10 months ago (2009-02-24 08:52:55 UTC) #2
Kevin Millikin (Chromium)
http://codereview.chromium.org/27084/diff/1002/3 File src/codegen-ia32.cc (right): http://codereview.chromium.org/27084/diff/1002/3#newcode2262 Line 2262: } else if (info == ALWAYS_FALSE) { On ...
11 years, 10 months ago (2009-02-24 08:56:32 UTC) #3
William Hesse
11 years, 10 months ago (2009-02-24 09:14:41 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698