[dart:io][windows] Fix analyzer warning for last commit

[dart:io][windows] Fix analyzer warning for last commit

Committed: https://github.com/dart-lang/sdk/commit/a18a8ae8ef486165bfbbddcffac669c0ad15140e

[zra, 2017-02-22 07:24:48]

zra@google.com changed reviewers:
+ fschneider@google.com

[zra, 2017-02-22 07:24:49]

TBR

[zra, 2017-02-22 07:26:02]

Description was changed from

==========
[dart:io][windows] Fix analyzer warning for last commit
==========

to

==========
[dart:io][windows] Fix analyzer warning for last commit

Committed:
https://github.com/dart-lang/sdk/commit/a18a8ae8ef486165bfbbddcffac669c0ad15140e
==========

[zra, 2017-02-22 07:26:03]

Committed patchset #1 (id:1) manually as
a18a8ae8ef486165bfbbddcffac669c0ad15140e (presubmit successful).

[Florian Schneider, 2017-02-22 15:56:55]

Lgtm w/ question

https://codereview.chromium.org/2708343002/diff/1/sdk/lib/io/stdio.dart
File sdk/lib/io/stdio.dart (right):

https://codereview.chromium.org/2708343002/diff/1/sdk/lib/io/stdio.dart#newco...
sdk/lib/io/stdio.dart:266: final IOSink _sink;
Would changing this to _IOSindImpl fix it as well instead?

[zra, 2017-02-22 17:35:14]

https://codereview.chromium.org/2708343002/diff/1/sdk/lib/io/stdio.dart
File sdk/lib/io/stdio.dart (right):

https://codereview.chromium.org/2708343002/diff/1/sdk/lib/io/stdio.dart#newco...
sdk/lib/io/stdio.dart:266: final IOSink _sink;
On 2017/02/22 15:56:55, Florian Schneider wrote:
> Would changing this to _IOSindImpl fix it as well instead?

There's probably a smarter way to do all this, but right now, _sink is a
different implementation of IOSink (a Socket, I think) when invoked from
_StdSocketSink.