chromecast/browser/metrics/cast_metrics_service_client.h - Issue 2708293002: Switch UKM service to properly mark upload data as UKM and not UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 2708293002: Switch UKM service to properly mark upload data as UKM and not UMA. (Closed)

Patch Set: no switch default now requires a default value Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/browser/metrics/cast_metrics_service_client.h

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h

index 64d2ad6624e56333bb0767ef204822f7a7eb5e28..a45cee9c58b2e8fd05b3158234c8a25748cb4b58 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.h

+++ b/chromecast/browser/metrics/cast_metrics_service_client.h

@@ -14,6 +14,7 @@

#include "base/memory/ref_counted.h"

#include "build/build_config.h"

#include "components/metrics/enabled_state_provider.h"

+#include "components/metrics/metrics_log_uploader.h"

#include "components/metrics/metrics_service_client.h"

class PrefRegistrySimple;

@@ -81,6 +82,7 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient,

std::unique_ptr<::metrics::MetricsLogUploader> CreateUploader(

const std::string& server_url,

const std::string& mime_type,

+ ::metrics::MetricsLogUploader::MetricServiceType service_type,

const base::Callback<void(int)>& on_upload_complete) override;

base::TimeDelta GetStandardUploadInterval() override;