content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java - Issue 2708243004: Auto convert content shell tests to JUnit4

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

Issue 2708243004: Auto convert content shell tests to JUnit4 (Closed)

Patch Set: Remove test that failed Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java ('K') | « content/public/android/javatests/src/org/chromium/content/browser/webcontents/WebContentsTest.java ('k') | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchCommon.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

index 1d87d5c807d1054f0005fd22ceaee7737b28ff56..33984834a8d5e53484e58c427278b2cd4d249df9 100644

--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java

@@ -11,6 +11,7 @@ import android.util.JsonReader;

import junit.framework.Assert;

+import org.chromium.base.Log;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content_public.browser.WebContents;

@@ -229,7 +230,9 @@ public class DOMUtils {

public static boolean clickNode(final ContentViewCore viewCore, String nodeId)

throws InterruptedException, TimeoutException {

+ Log.d("#YOLAND", "about to click node in clickNode");

scrollNodeIntoView(viewCore.getWebContents(), nodeId);

+ Log.d("#YOLAND", "scrolled into view");

int[] clickTarget = getClickTargetForNode(viewCore, nodeId);

return TouchCommon.singleClickView(

viewCore.getContainerView(), clickTarget[0], clickTarget[1]);