content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java - Issue 2708243004: Auto convert content shell tests to JUnit4

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java

Issue 2708243004: Auto convert content shell tests to JUnit4 (Closed)

Patch Set: New test added from WebContentsTest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayCoercionTest.java ('K') | « content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBareboneTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java » ('j') | content/public/android/javatests/src/org/chromium/content/browser/webcontents/WebContentsTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java

index 1ea2e883524840a5226f9f59918c96bbe3e8df7e..623344c749b6fb0551bd85cb8614d8aa4adecbb0 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java

@@ -181,6 +181,7 @@ public class JavaBridgeBasicsTest extends JavaBridgeTestBase {

public void testRemoveObjectNotAdded() throws Throwable {

TestCallbackHelperContainer.OnPageFinishedHelper onPageFinishedHelper =

getTestCallBackHelperContainer().getOnPageFinishedHelper();

boliu 2017/03/10 18:32:32 remove this empty line change

the real yoland 2017/03/10 19:31:58 Done

int currentCallCount = onPageFinishedHelper.getCallCount();

runTestOnUiThread(new Runnable() {

@Override