Auto convert content shell tests to JUnit4

content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java

-// Copyright 2013 The Chromium Authors. All rights reserved.
+// Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.support.test.filters.SmallTest;
-import android.test.InstrumentationTestCase;
 
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.library_loader.LibraryProcessType;
 import org.chromium.base.library_loader.LoaderErrors;
 import org.chromium.base.library_loader.ProcessInitException;
+import org.junit.Test;

[jbudorick, 2017/03/01 23:10:19]

import order?

I'm surprised this wasn't flagged either during the build or on upload.

[the real yoland, 2017/03/08 23:35:31]

Oops, my bad, I bypassed this one.
Fixed now

+import org.chromium.base.test.BaseJUnit4ClassRunner;
+import org.junit.runner.RunWith;
+import android.support.test.InstrumentationRegistry;
+import org.junit.Assert;
+import org.junit.Before;
 
 /**
  * Test of BrowserStartupController
  */
-public class BrowserStartupControllerTest extends InstrumentationTestCase {
+@RunWith(BaseJUnit4ClassRunner.class)
+public class BrowserStartupControllerTest {
 
     private TestBrowserStartupController mController;
 
     private static class TestBrowserStartupController extends BrowserStartupController {
 
         private int mStartupResult;
         private boolean mLibraryLoadSucceeds;
         private int mInitializedCounter = 0;
 
         @Override
@@ skipping 48 matching lines @@
         }
 
         @Override
         public void onFailure() {
             assert !mHasStartupResult;
             mWasFailure = true;
             mHasStartupResult = true;
         }
     }
 
-    @Override
-    protected void setUp() throws Exception {
-        super.setUp();
+    @Before
+    

[jbudorick, 2017/03/01 23:10:19]

There shouldn't be a blank line here.

[the real yoland, 2017/03/08 23:35:31]

Done, fixed for all tests

+    public void setUp() throws Exception {
         mController = new TestBrowserStartupController();
         // Setting the static singleton instance field enables more correct testing, since it is
         // is possible to call {@link BrowserStartupController#browserStartupComplete(int)} instead
         // of {@link BrowserStartupController#executeEnqueuedCallbacks(int, boolean)} directly.
         BrowserStartupController.overrideInstanceForTest(mController);
     }
 
+    @Test
     @SmallTest
     public void testSingleAsynchronousStartupRequest() {
         mController.mStartupResult = BrowserStartupController.STARTUP_SUCCESS;
         mController.mLibraryLoadSucceeds = true;
         final TestStartupCallback callback = new TestStartupCallback();
 
         // Kick off the asynchronous startup request.
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesAsync(true, callback);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
             }
         });
 
-        assertTrue("Asynchronous mode should have been set.",
+        Assert.assertTrue("Asynchronous mode should have been set.",
                 BrowserStartupController.browserMayStartAsynchonously());
-        assertEquals("The browser process should have been initialized one time.", 1,
+        Assert.assertEquals("The browser process should have been initialized one time.", 1,
                 mController.initializedCounter());
 
         // Wait for callbacks to complete.
-        getInstrumentation().waitForIdleSync();
+        InstrumentationRegistry.getInstrumentation().waitForIdleSync();
 
-        assertTrue("Callback should have been executed.", callback.mHasStartupResult);
-        assertTrue("Callback should have been a success.", callback.mWasSuccess);
-        assertFalse("Callback should be told that the browser process was not already started.",
+        Assert.assertTrue("Callback should have been executed.", callback.mHasStartupResult);
+        Assert.assertTrue("Callback should have been a success.", callback.mWasSuccess);
+        Assert.assertFalse("Callback should be told that the browser process was not already started.",
                 callback.mAlreadyStarted);
     }
 
+    @Test
     @SmallTest
     public void testMultipleAsynchronousStartupRequests() {
         mController.mStartupResult = BrowserStartupController.STARTUP_SUCCESS;
         mController.mLibraryLoadSucceeds = true;
         final TestStartupCallback callback1 = new TestStartupCallback();
         final TestStartupCallback callback2 = new TestStartupCallback();
         final TestStartupCallback callback3 = new TestStartupCallback();
 
         // Kick off the asynchronous startup requests.
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesAsync(true, callback1);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
             }
         });
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesAsync(true, callback2);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
             }
         });
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 mController.addStartupCompletedObserver(callback3);
             }
         });
 
-        assertTrue("Asynchronous mode should have been set.",
+        Assert.assertTrue("Asynchronous mode should have been set.",
                 BrowserStartupController.browserMayStartAsynchonously());
-        assertEquals("The browser process should have been initialized one time.", 1,
+        Assert.assertEquals("The browser process should have been initialized one time.", 1,
                 mController.initializedCounter());
 
         // Wait for callbacks to complete.
-        getInstrumentation().waitForIdleSync();
+        InstrumentationRegistry.getInstrumentation().waitForIdleSync();
 
-        assertTrue("Callback 1 should have been executed.", callback1.mHasStartupResult);
-        assertTrue("Callback 1 should have been a success.", callback1.mWasSuccess);
-        assertTrue("Callback 2 should have been executed.", callback2.mHasStartupResult);
-        assertTrue("Callback 2 should have been a success.", callback2.mWasSuccess);
-        assertTrue("Callback 3 should have been executed.", callback3.mHasStartupResult);
-        assertTrue("Callback 3 should have been a success.", callback3.mWasSuccess);
+        Assert.assertTrue("Callback 1 should have been executed.", callback1.mHasStartupResult);
+        Assert.assertTrue("Callback 1 should have been a success.", callback1.mWasSuccess);
+        Assert.assertTrue("Callback 2 should have been executed.", callback2.mHasStartupResult);
+        Assert.assertTrue("Callback 2 should have been a success.", callback2.mWasSuccess);
+        Assert.assertTrue("Callback 3 should have been executed.", callback3.mHasStartupResult);
+        Assert.assertTrue("Callback 3 should have been a success.", callback3.mWasSuccess);
         // Some startup tasks might have been enqueued after the browser process was started, but
         // not the first one which kicked of the startup.
-        assertFalse("Callback 1 should be told that the browser process was not already started.",
+        Assert.assertFalse("Callback 1 should be told that the browser process was not already started.",
                 callback1.mAlreadyStarted);
     }
 
+    @Test
     @SmallTest
     public void testConsecutiveAsynchronousStartupRequests() {
         mController.mStartupResult = BrowserStartupController.STARTUP_SUCCESS;
         mController.mLibraryLoadSucceeds = true;
         final TestStartupCallback callback1 = new TestStartupCallback();
         final TestStartupCallback callback2 = new TestStartupCallback();
 
         // Kick off the asynchronous startup requests.
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesAsync(true, callback1);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
             }
         });
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 mController.addStartupCompletedObserver(callback2);
             }
         });
 
-        assertTrue("Asynchronous mode should have been set.",
+        Assert.assertTrue("Asynchronous mode should have been set.",
                 BrowserStartupController.browserMayStartAsynchonously());
-        assertEquals("The browser process should have been initialized one time.", 1,
+        Assert.assertEquals("The browser process should have been initialized one time.", 1,
                 mController.initializedCounter());
 
         // Wait for callbacks to complete.
-        getInstrumentation().waitForIdleSync();
+        InstrumentationRegistry.getInstrumentation().waitForIdleSync();
 
-        assertTrue("Callback 1 should have been executed.", callback1.mHasStartupResult);
-        assertTrue("Callback 1 should have been a success.", callback1.mWasSuccess);
-        assertTrue("Callback 2 should have been executed.", callback2.mHasStartupResult);
-        assertTrue("Callback 2 should have been a success.", callback2.mWasSuccess);
+        Assert.assertTrue("Callback 1 should have been executed.", callback1.mHasStartupResult);
+        Assert.assertTrue("Callback 1 should have been a success.", callback1.mWasSuccess);
+        Assert.assertTrue("Callback 2 should have been executed.", callback2.mHasStartupResult);
+        Assert.assertTrue("Callback 2 should have been a success.", callback2.mWasSuccess);
 
         final TestStartupCallback callback3 = new TestStartupCallback();
         final TestStartupCallback callback4 = new TestStartupCallback();
 
         // Kick off more asynchronous startup requests.
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesAsync(true, callback3);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
             }
         });
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 mController.addStartupCompletedObserver(callback4);
             }
         });
 
         // Wait for callbacks to complete.
-        getInstrumentation().waitForIdleSync();
+        InstrumentationRegistry.getInstrumentation().waitForIdleSync();
 
-        assertTrue("Callback 3 should have been executed.", callback3.mHasStartupResult);
-        assertTrue("Callback 3 should have been a success.", callback3.mWasSuccess);
-        assertTrue("Callback 3 should be told that the browser process was already started.",
+        Assert.assertTrue("Callback 3 should have been executed.", callback3.mHasStartupResult);
+        Assert.assertTrue("Callback 3 should have been a success.", callback3.mWasSuccess);
+        Assert.assertTrue("Callback 3 should be told that the browser process was already started.",
                 callback3.mAlreadyStarted);
-        assertTrue("Callback 4 should have been executed.", callback4.mHasStartupResult);
-        assertTrue("Callback 4 should have been a success.", callback4.mWasSuccess);
-        assertTrue("Callback 4 should be told that the browser process was already started.",
+        Assert.assertTrue("Callback 4 should have been executed.", callback4.mHasStartupResult);
+        Assert.assertTrue("Callback 4 should have been a success.", callback4.mWasSuccess);
+        Assert.assertTrue("Callback 4 should be told that the browser process was already started.",
                 callback4.mAlreadyStarted);
     }
 
+    @Test
     @SmallTest
     public void testSingleFailedAsynchronousStartupRequest() {
         mController.mStartupResult = BrowserStartupController.STARTUP_FAILURE;
         mController.mLibraryLoadSucceeds = true;
         final TestStartupCallback callback = new TestStartupCallback();
 
         // Kick off the asynchronous startup request.
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesAsync(true, callback);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
             }
         });
 
-        assertTrue("Asynchronous mode should have been set.",
+        Assert.assertTrue("Asynchronous mode should have been set.",
                 BrowserStartupController.browserMayStartAsynchonously());
-        assertEquals("The browser process should have been initialized one time.", 1,
+        Assert.assertEquals("The browser process should have been initialized one time.", 1,
                 mController.initializedCounter());
 
         // Wait for callbacks to complete.
-        getInstrumentation().waitForIdleSync();
+        InstrumentationRegistry.getInstrumentation().waitForIdleSync();
 
-        assertTrue("Callback should have been executed.", callback.mHasStartupResult);
-        assertTrue("Callback should have been a failure.", callback.mWasFailure);
+        Assert.assertTrue("Callback should have been executed.", callback.mHasStartupResult);
+        Assert.assertTrue("Callback should have been a failure.", callback.mWasFailure);
     }
 
+    @Test
     @SmallTest
     public void testConsecutiveFailedAsynchronousStartupRequests() {
         mController.mStartupResult = BrowserStartupController.STARTUP_FAILURE;
         mController.mLibraryLoadSucceeds = true;
         final TestStartupCallback callback1 = new TestStartupCallback();
         final TestStartupCallback callback2 = new TestStartupCallback();
 
         // Kick off the asynchronous startup requests.
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesAsync(true, callback1);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
             }
         });
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 mController.addStartupCompletedObserver(callback2);
             }
         });
 
-        assertTrue("Asynchronous mode should have been set.",
+        Assert.assertTrue("Asynchronous mode should have been set.",
                 BrowserStartupController.browserMayStartAsynchonously());
-        assertEquals("The browser process should have been initialized one time.", 1,
+        Assert.assertEquals("The browser process should have been initialized one time.", 1,
                 mController.initializedCounter());
 
         // Wait for callbacks to complete.
-        getInstrumentation().waitForIdleSync();
+        InstrumentationRegistry.getInstrumentation().waitForIdleSync();
 
-        assertTrue("Callback 1 should have been executed.", callback1.mHasStartupResult);
-        assertTrue("Callback 1 should have been a failure.", callback1.mWasFailure);
-        assertTrue("Callback 2 should have been executed.", callback2.mHasStartupResult);
-        assertTrue("Callback 2 should have been a failure.", callback2.mWasFailure);
+        Assert.assertTrue("Callback 1 should have been executed.", callback1.mHasStartupResult);
+        Assert.assertTrue("Callback 1 should have been a failure.", callback1.mWasFailure);
+        Assert.assertTrue("Callback 2 should have been executed.", callback2.mHasStartupResult);
+        Assert.assertTrue("Callback 2 should have been a failure.", callback2.mWasFailure);
 
         final TestStartupCallback callback3 = new TestStartupCallback();
         final TestStartupCallback callback4 = new TestStartupCallback();
 
         // Kick off more asynchronous startup requests.
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesAsync(true, callback3);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
             }
         });
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 mController.addStartupCompletedObserver(callback4);
             }
         });
 
         // Wait for callbacks to complete.
-        getInstrumentation().waitForIdleSync();
+        InstrumentationRegistry.getInstrumentation().waitForIdleSync();
 
-        assertTrue("Callback 3 should have been executed.", callback3.mHasStartupResult);
-        assertTrue("Callback 3 should have been a failure.", callback3.mWasFailure);
-        assertTrue("Callback 4 should have been executed.", callback4.mHasStartupResult);
-        assertTrue("Callback 4 should have been a failure.", callback4.mWasFailure);
+        Assert.assertTrue("Callback 3 should have been executed.", callback3.mHasStartupResult);
+        Assert.assertTrue("Callback 3 should have been a failure.", callback3.mWasFailure);
+        Assert.assertTrue("Callback 4 should have been executed.", callback4.mHasStartupResult);
+        Assert.assertTrue("Callback 4 should have been a failure.", callback4.mWasFailure);
     }
 
+    @Test
     @SmallTest
     public void testSingleSynchronousRequest() {
         mController.mStartupResult = BrowserStartupController.STARTUP_SUCCESS;
         mController.mLibraryLoadSucceeds = true;
         // Kick off the synchronous startup.
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesSync(false);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
             }
         });
-        assertFalse("Synchronous mode should have been set",
+        Assert.assertFalse("Synchronous mode should have been set",
                 BrowserStartupController.browserMayStartAsynchonously());
 
-        assertEquals("The browser process should have been initialized one time.", 1,
+        Assert.assertEquals("The browser process should have been initialized one time.", 1,
                 mController.initializedCounter());
     }
 
+    @Test
     @SmallTest
     public void testAsyncThenSyncRequests() {
         mController.mStartupResult = BrowserStartupController.STARTUP_SUCCESS;
         mController.mLibraryLoadSucceeds = true;
         final TestStartupCallback callback = new TestStartupCallback();
 
         // Kick off the startups.
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesAsync(true, callback);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
                 // To ensure that the async startup doesn't complete too soon we have
                 // to do both these in a since Runnable instance. This avoids the
                 // unpredictable race that happens in real situations.
                 try {
                     mController.startBrowserProcessesSync(false);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
             }
         });
-        assertFalse("Synchronous mode should have been set",
+        Assert.assertFalse("Synchronous mode should have been set",
                 BrowserStartupController.browserMayStartAsynchonously());
 
-        assertEquals("The browser process should have been initialized twice.", 2,
+        Assert.assertEquals("The browser process should have been initialized twice.", 2,
                 mController.initializedCounter());
 
-        assertTrue("Callback should have been executed.", callback.mHasStartupResult);
-        assertTrue("Callback should have been a success.", callback.mWasSuccess);
-        assertFalse("Callback should be told that the browser process was not already started.",
+        Assert.assertTrue("Callback should have been executed.", callback.mHasStartupResult);
+        Assert.assertTrue("Callback should have been a success.", callback.mWasSuccess);
+        Assert.assertFalse("Callback should be told that the browser process was not already started.",
                 callback.mAlreadyStarted);
     }
 
+    @Test
     @SmallTest
     public void testSyncThenAsyncRequests() {
         mController.mStartupResult = BrowserStartupController.STARTUP_SUCCESS;
         mController.mLibraryLoadSucceeds = true;
         final TestStartupCallback callback = new TestStartupCallback();
 
         // Do a synchronous startup first.
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesSync(false);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
             }
         });
 
-        assertEquals("The browser process should have been initialized once.", 1,
+        Assert.assertEquals("The browser process should have been initialized once.", 1,
                 mController.initializedCounter());
 
-        assertFalse("Synchronous mode should have been set",
+        Assert.assertFalse("Synchronous mode should have been set",
                 BrowserStartupController.browserMayStartAsynchonously());
 
         // Kick off the asynchronous startup request. This should just queue the callback.
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesAsync(true, callback);
                 } catch (Exception e) {
-                    fail("Browser should have started successfully");
+                    Assert.fail("Browser should have started successfully");
                 }
             }
         });
 
-        assertEquals("The browser process should not have been initialized a second time.", 1,
+        Assert.assertEquals("The browser process should not have been initialized a second time.", 1,
                 mController.initializedCounter());
 
         // Wait for callbacks to complete.
-        getInstrumentation().waitForIdleSync();
+        InstrumentationRegistry.getInstrumentation().waitForIdleSync();
 
-        assertTrue("Callback should have been executed.", callback.mHasStartupResult);
-        assertTrue("Callback should have been a success.", callback.mWasSuccess);
-        assertTrue("Callback should be told that the browser process was already started.",
+        Assert.assertTrue("Callback should have been executed.", callback.mHasStartupResult);
+        Assert.assertTrue("Callback should have been a success.", callback.mWasSuccess);
+        Assert.assertTrue("Callback should be told that the browser process was already started.",
                 callback.mAlreadyStarted);
     }
 
+    @Test
     @SmallTest
     public void testLibraryLoadFails() {
         mController.mLibraryLoadSucceeds = false;
         final TestStartupCallback callback = new TestStartupCallback();
 
         // Kick off the asynchronous startup request.
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 try {
                     mController.startBrowserProcessesAsync(true, callback);
-                    fail("Browser should not have started successfully");
+                    Assert.fail("Browser should not have started successfully");
                 } catch (Exception e) {
                     // Exception expected, ignore.
                 }
             }
         });
 
-        assertEquals("The browser process should not have been initialized.", 0,
+        Assert.assertEquals("The browser process should not have been initialized.", 0,
                 mController.initializedCounter());
 
         // Wait for callbacks to complete.
-        getInstrumentation().waitForIdleSync();
+        InstrumentationRegistry.getInstrumentation().waitForIdleSync();
     }
 
 }