Auto convert content shell tests to JUnit4

content/public/android/javatests/src/org/chromium/content/browser/webcontents/WebContentsTest.java

-// Copyright 2015 The Chromium Authors. All rights reserved.
+// Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.webcontents;
 
 import android.annotation.SuppressLint;
 import android.content.Intent;
 import android.os.Bundle;
 import android.os.Parcel;
 import android.support.test.filters.SmallTest;
 
+import org.junit.Assert;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
 import org.chromium.base.ThreadUtils;
+import org.chromium.base.test.BaseJUnit4ClassRunner;
 import org.chromium.content_public.browser.RenderFrameHost;
 import org.chromium.content_public.browser.WebContents;
 import org.chromium.content_shell.Shell;
 import org.chromium.content_shell_apk.ContentShellActivity;
-import org.chromium.content_shell_apk.ContentShellTestBase;
+import org.chromium.content_shell_apk.ContentShellActivityTestRule;
 
 import java.util.concurrent.Callable;
 import java.util.concurrent.ExecutionException;
 
 /**
  * Test various Java WebContents specific features.
  * TODO(dtrainor): Add more testing for the WebContents methods.
  */
-public class WebContentsTest extends ContentShellTestBase {
+@RunWith(BaseJUnit4ClassRunner.class)
+public class WebContentsTest {
+    @Rule
+    public ContentShellActivityTestRule mActivityTestRule = new ContentShellActivityTestRule();
+
     private static final String TEST_URL_1 = "about://blank";
     private static final String WEB_CONTENTS_KEY = "WEBCONTENTSKEY";
     private static final String PARCEL_STRING_TEST_DATA = "abcdefghijklmnopqrstuvwxyz";
 
     /**
      * Check that {@link WebContents#isDestroyed()} works as expected.
      * TODO(dtrainor): Test this using {@link WebContents#destroy()} instead once it is possible to
      * build a {@link WebContents} directly in the content/ layer.
      *
      * @throws InterruptedException
      * @throws ExecutionException
      */
+    @Test
     @SmallTest
     public void testWebContentsIsDestroyedMethod() throws InterruptedException, ExecutionException {
-        final ContentShellActivity activity = launchContentShellWithUrl(TEST_URL_1);
-        waitForActiveShellToBeDoneLoading();
+        final ContentShellActivity activity =
+                mActivityTestRule.launchContentShellWithUrl(TEST_URL_1);
+        mActivityTestRule.waitForActiveShellToBeDoneLoading();
         WebContents webContents = activity.getActiveWebContents();
 
-        assertFalse("WebContents incorrectly marked as destroyed",
-                isWebContentsDestroyed(webContents));
+        Assert.assertFalse(
+                "WebContents incorrectly marked as destroyed", isWebContentsDestroyed(webContents));
 
         // Launch a new shell.
         Shell originalShell = activity.getActiveShell();
-        loadNewShell(TEST_URL_1);
-        assertNotSame("New shell not created", activity.getActiveShell(), originalShell);
+        mActivityTestRule.loadNewShell(TEST_URL_1);
+        Assert.assertNotSame("New shell not created", activity.getActiveShell(), originalShell);
 
-        assertTrue("WebContents incorrectly marked as not destroyed",
+        Assert.assertTrue("WebContents incorrectly marked as not destroyed",
                 isWebContentsDestroyed(webContents));
     }
 
     /**
      * Check that it is possible to serialize and deserialize a WebContents object through Parcels.
      *
      * @throws InterruptedException
      */
+    @Test
     @SmallTest
     public void testWebContentsSerializeDeserializeInParcel() throws InterruptedException {
-        launchContentShellWithUrl(TEST_URL_1);
-        waitForActiveShellToBeDoneLoading();
-        WebContents webContents = getWebContents();
+        mActivityTestRule.launchContentShellWithUrl(TEST_URL_1);
+        mActivityTestRule.waitForActiveShellToBeDoneLoading();
+        WebContents webContents = mActivityTestRule.getWebContents();
 
         Parcel parcel = Parcel.obtain();
 
         try {
             // Serialize the WebContents.
             parcel.writeParcelable(webContents, 0);
 
             // Read back the WebContents.
             parcel.setDataPosition(0);
             WebContents deserializedWebContents = parcel.readParcelable(
                     WebContents.class.getClassLoader());
 
             // Make sure they're equal.
-            assertEquals("Deserialized object does not match",
-                    webContents, deserializedWebContents);
+            Assert.assertEquals(
+                    "Deserialized object does not match", webContents, deserializedWebContents);
         } finally {
             parcel.recycle();
         }
     }
 
     /**
      * Check that it is possible to serialize and deserialize a WebContents object through Bundles.
      * @throws InterruptedException
      */
+    @Test
     @SmallTest
     // TODO(crbug.com/635567): Fix this properly.
     @SuppressLint("ParcelClassLoader")
     public void testWebContentsSerializeDeserializeInBundle() throws InterruptedException {
-        launchContentShellWithUrl(TEST_URL_1);
-        waitForActiveShellToBeDoneLoading();
-        WebContents webContents = getWebContents();
+        mActivityTestRule.launchContentShellWithUrl(TEST_URL_1);
+        mActivityTestRule.waitForActiveShellToBeDoneLoading();
+        WebContents webContents = mActivityTestRule.getWebContents();
 
         // Use a parcel to force the Bundle to actually serialize and deserialize, otherwise it can
         // cache the WebContents object.
         Parcel parcel = Parcel.obtain();
 
         try {
             // Create a bundle and put the WebContents in it.
             Bundle bundle = new Bundle();
             bundle.putParcelable(WEB_CONTENTS_KEY, webContents);
 
             // Serialize the Bundle.
             parcel.writeBundle(bundle);
 
             // Read back the Bundle.
             parcel.setDataPosition(0);
             Bundle deserializedBundle = parcel.readBundle();
 
             // Read back the WebContents.
             deserializedBundle.setClassLoader(WebContents.class.getClassLoader());
             WebContents deserializedWebContents =
                     deserializedBundle.getParcelable(WEB_CONTENTS_KEY);
 
             // Make sure they're equal.
-            assertEquals("Deserialized object does not match",
-                    webContents, deserializedWebContents);
+            Assert.assertEquals(
+                    "Deserialized object does not match", webContents, deserializedWebContents);
         } finally {
             parcel.recycle();
         }
     }
 
     /**
      * Check that it is possible to serialize and deserialize a WebContents object through Intents.
      * @throws InterruptedException
      */
+    @Test
     @SmallTest
     // TODO(crbug.com/635567): Fix this properly.
     @SuppressLint("ParcelClassLoader")
     public void testWebContentsSerializeDeserializeInIntent() throws InterruptedException {
-        launchContentShellWithUrl(TEST_URL_1);
-        waitForActiveShellToBeDoneLoading();
-        WebContents webContents = getWebContents();
+        mActivityTestRule.launchContentShellWithUrl(TEST_URL_1);
+        mActivityTestRule.waitForActiveShellToBeDoneLoading();
+        WebContents webContents = mActivityTestRule.getWebContents();
 
         // Use a parcel to force the Intent to actually serialize and deserialize, otherwise it can
         // cache the WebContents object.
         Parcel parcel = Parcel.obtain();
 
         try {
             // Create an Intent and put the WebContents in it.
             Intent intent = new Intent();
             intent.putExtra(WEB_CONTENTS_KEY, webContents);
 
             // Serialize the Intent
             parcel.writeParcelable(intent, 0);
 
             // Read back the Intent.
             parcel.setDataPosition(0);
             Intent deserializedIntent = parcel.readParcelable(null);
 
             // Read back the WebContents.
             deserializedIntent.setExtrasClassLoader(WebContents.class.getClassLoader());
             WebContents deserializedWebContents =
                     (WebContents) deserializedIntent.getParcelableExtra(WEB_CONTENTS_KEY);
 
             // Make sure they're equal.
-            assertEquals("Deserialized object does not match",
-                    webContents, deserializedWebContents);
+            Assert.assertEquals(
+                    "Deserialized object does not match", webContents, deserializedWebContents);
         } finally {
             parcel.recycle();
         }
     }
 
     /**
      * Check that attempting to deserialize a WebContents object from a Parcel from another process
      * instance fails.
      * @throws InterruptedException
      */
+    @Test
     @SmallTest
     public void testWebContentsFailDeserializationAcrossProcessBoundary()
             throws InterruptedException {
-        launchContentShellWithUrl(TEST_URL_1);
-        waitForActiveShellToBeDoneLoading();
-        WebContents webContents = getWebContents();
+        mActivityTestRule.launchContentShellWithUrl(TEST_URL_1);
+        mActivityTestRule.waitForActiveShellToBeDoneLoading();
+        WebContents webContents = mActivityTestRule.getWebContents();
 
         Parcel parcel = Parcel.obtain();
 
         try {
             // Serialize the WebContents.
             parcel.writeParcelable(webContents, 0);
 
             // Invalidate all serialized WebContents.
             WebContentsImpl.invalidateSerializedWebContentsForTesting();
 
             // Try to read back the WebContents.
             parcel.setDataPosition(0);
             WebContents deserializedWebContents = parcel.readParcelable(
                     WebContents.class.getClassLoader());
 
             // Make sure we weren't able to deserialize the WebContents.
-            assertNull("Unexpectedly deserialized a WebContents", deserializedWebContents);
+            Assert.assertNull("Unexpectedly deserialized a WebContents", deserializedWebContents);
         } finally {
             parcel.recycle();
         }
     }
 
     /**
      * Check that serializing a destroyed WebContents always results in a null deserialized
      * WebContents.
      * @throws InterruptedException
      * @throws ExecutionException
      */
+    @Test
     @SmallTest
     public void testSerializingADestroyedWebContentsDoesNotDeserialize()
             throws InterruptedException, ExecutionException {
-        ContentShellActivity activity = launchContentShellWithUrl(TEST_URL_1);
-        waitForActiveShellToBeDoneLoading();
+        ContentShellActivity activity = mActivityTestRule.launchContentShellWithUrl(TEST_URL_1);
+        mActivityTestRule.waitForActiveShellToBeDoneLoading();
         WebContents webContents = activity.getActiveWebContents();
-        loadNewShell(TEST_URL_1);
+        mActivityTestRule.loadNewShell(TEST_URL_1);
 
-        assertTrue("WebContents not destroyed", isWebContentsDestroyed(webContents));
+        Assert.assertTrue("WebContents not destroyed", isWebContentsDestroyed(webContents));
 
         Parcel parcel = Parcel.obtain();
 
         try {
             // Serialize the WebContents.
             parcel.writeParcelable(webContents, 0);
 
             // Try to read back the WebContents.
             parcel.setDataPosition(0);
             WebContents deserializedWebContents = parcel.readParcelable(
                     WebContents.class.getClassLoader());
 
             // Make sure we weren't able to deserialize the WebContents.
-            assertNull("Unexpectedly deserialized a destroyed WebContents",
-                    deserializedWebContents);
+            Assert.assertNull(
+                    "Unexpectedly deserialized a destroyed WebContents", deserializedWebContents);
         } finally {
             parcel.recycle();
         }
     }
 
     /**
      * Check that destroying a WebContents after serializing it always results in a null
      * deserialized WebContents.
      * @throws InterruptedException
      * @throws ExecutionException
      */
+    @Test
     @SmallTest
     public void testDestroyingAWebContentsAfterSerializingDoesNotDeserialize()
             throws InterruptedException, ExecutionException {
-        ContentShellActivity activity = launchContentShellWithUrl(TEST_URL_1);
-        waitForActiveShellToBeDoneLoading();
+        ContentShellActivity activity = mActivityTestRule.launchContentShellWithUrl(TEST_URL_1);
+        mActivityTestRule.waitForActiveShellToBeDoneLoading();
         WebContents webContents = activity.getActiveWebContents();
 
         Parcel parcel = Parcel.obtain();
 
         try {
             // Serialize the WebContents.
             parcel.writeParcelable(webContents, 0);
 
             // Destroy the WebContents.
-            loadNewShell(TEST_URL_1);
-            assertTrue("WebContents not destroyed", isWebContentsDestroyed(webContents));
+            mActivityTestRule.loadNewShell(TEST_URL_1);
+            Assert.assertTrue("WebContents not destroyed", isWebContentsDestroyed(webContents));
 
             // Try to read back the WebContents.
             parcel.setDataPosition(0);
             WebContents deserializedWebContents = parcel.readParcelable(
                     WebContents.class.getClassLoader());
 
             // Make sure we weren't able to deserialize the WebContents.
-            assertNull("Unexpectedly deserialized a destroyed WebContents",
-                    deserializedWebContents);
+            Assert.assertNull(
+                    "Unexpectedly deserialized a destroyed WebContents", deserializedWebContents);
         } finally {
             parcel.recycle();
         }
     }
 
     /**
      * Check that failing a WebContents deserialization doesn't corrupt subsequent data in the
      * Parcel.
      * @throws InterruptedException
      */
+    @Test
     @SmallTest
-    public void testFailedDeserializationDoesntCorruptParcel()
-            throws InterruptedException {
-        launchContentShellWithUrl(TEST_URL_1);
-        waitForActiveShellToBeDoneLoading();
-        WebContents webContents = getWebContents();
+    public void testFailedDeserializationDoesntCorruptParcel() throws InterruptedException {
+        mActivityTestRule.launchContentShellWithUrl(TEST_URL_1);
+        mActivityTestRule.waitForActiveShellToBeDoneLoading();
+        WebContents webContents = mActivityTestRule.getWebContents();
 
         Parcel parcel = Parcel.obtain();
 
         try {
             // Serialize the WebContents.
             parcel.writeParcelable(webContents, 0);
 
             // Serialize a String after the WebContents.
             parcel.writeString(PARCEL_STRING_TEST_DATA);
 
             // Invalidate all serialized WebContents.
             WebContentsImpl.invalidateSerializedWebContentsForTesting();
 
             // Try to read back the WebContents.
             parcel.setDataPosition(0);
             WebContents deserializedWebContents = parcel.readParcelable(
                     WebContents.class.getClassLoader());
 
             // Make sure we weren't able to deserialize the WebContents.
-            assertNull("Unexpectedly deserialized a WebContents", deserializedWebContents);
+            Assert.assertNull("Unexpectedly deserialized a WebContents", deserializedWebContents);
 
             // Make sure we can properly deserialize the String after the WebContents.
-            assertEquals("Failing to read the WebContents corrupted the parcel",
+            Assert.assertEquals("Failing to read the WebContents corrupted the parcel",
                     PARCEL_STRING_TEST_DATA, parcel.readString());
         } finally {
             parcel.recycle();
         }
     }
 
     /**
      * Check that the main frame associated with the WebContents is not null
      * and corresponds with the test URL.
      *
      * @throws InterruptedException
      */
+    @Test
     @SmallTest
     public void testWebContentsMainFrame() throws InterruptedException {

[boliu, 2017/03/10 18:32:32]

this needs a rebase.. depending on timing of when
https://codereview.chromium.org/2681933002/ lands again

[the real yoland, 2017/03/10 19:31:58]

Will do

[boliu, 2017/03/10 19:36:10]

That CL just got cq-ed again, so guess you have to wait a bit..

-        final ContentShellActivity activity = launchContentShellWithUrl(TEST_URL_1);
-        waitForActiveShellToBeDoneLoading();
+        final ContentShellActivity activity =
+                mActivityTestRule.launchContentShellWithUrl(TEST_URL_1);
+        mActivityTestRule.waitForActiveShellToBeDoneLoading();
         final WebContents webContents = activity.getActiveWebContents();
 
         ThreadUtils.postOnUiThread(new Runnable() {
             @Override
             public void run() {
                 RenderFrameHost frameHost = webContents.getMainFrame();
 
-                assertNotNull(frameHost);
+                Assert.assertNotNull(frameHost);
 
-                assertEquals("RenderFrameHost has incorrect last committed URL", "about:blank",
-                        frameHost.getLastCommittedURL());
+                Assert.assertEquals("RenderFrameHost has incorrect last committed URL",
+                        "about:blank", frameHost.getLastCommittedURL());
 
                 WebContents associatedWebContents = WebContentsImpl.fromRenderFrameHost(frameHost);
-                assertEquals("RenderFrameHost associated with different WebContents", webContents,
-                        associatedWebContents);
+                Assert.assertEquals("RenderFrameHost associated with different WebContents",
+                        webContents, associatedWebContents);
             }
         });
     }
 
     private boolean isWebContentsDestroyed(final WebContents webContents) {
         return ThreadUtils.runOnUiThreadBlockingNoException(new Callable<Boolean>() {
             @Override
             public Boolean call() throws Exception {
                 return webContents.isDestroyed();
             }
         });
     }
 }