chrome/browser/chromeos/printing/cups_print_job_notification_manager.h - Issue 2708233006: Report print jobs that are aborted by CUPS as errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/printing/cups_print_job_notification_manager.h

Issue 2708233006: Report print jobs that are aborted by CUPS as errors. (Closed)

Patch Set: address comments from xdai Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/printing/cups_print_job_notification.cc ('k') | chrome/browser/chromeos/printing/cups_print_job_notification_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/printing/cups_print_job_notification_manager.h

diff --git a/chrome/browser/chromeos/printing/cups_print_job_notification_manager.h b/chrome/browser/chromeos/printing/cups_print_job_notification_manager.h

index bad14c895cabc268c7a378f00d773a8146a614d8..1f7c3049c34da01ca7d9677effc197167f3bcd35 100644

--- a/chrome/browser/chromeos/printing/cups_print_job_notification_manager.h

+++ b/chrome/browser/chromeos/printing/cups_print_job_notification_manager.h

@@ -9,6 +9,7 @@

#include <string>

#include <unordered_map>

+#include "base/macros.h"

#include "chrome/browser/chromeos/printing/cups_print_job_manager.h"

#include "chrome/browser/chromeos/printing/cups_print_job_notification.h"

@@ -36,8 +37,11 @@ class CupsPrintJobNotificationManager : public CupsPrintJobManager::Observer {

void OnPrintJobResumed(CupsPrintJob* job) override;

void OnPrintJobDone(CupsPrintJob* job) override;

void OnPrintJobError(CupsPrintJob* job) override;

+ void OnPrintJobCancelled(CupsPrintJob* job) override;

private:

+ void UpdateNotification(CupsPrintJob* job);

PrintJobNotificationMap notification_map_;

CupsPrintJobManager* print_job_manager_;

Profile* profile_;