Report print jobs that are aborted by CUPS as errors.

chrome/browser/chromeos/printing/cups_print_job_notification.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_PRINTING_CUPS_PRINT_JOB_NOTIFICATION_H_
 #define CHROME_BROWSER_CHROMEOS_PRINTING_CUPS_PRINT_JOB_NOTIFICATION_H_
 
+#include <memory>
+#include <string>
+#include <vector>

[xdai1, 2017/02/24 23:31:52]

Just curious: Normally I don't proactively add more head files if the compiler
doesn't complain. Any guide rules about when should add more head files? 

[skau, 2017/02/25 00:16:06]

It shows up as a linter warning when I run 'git cl lint'.  It also improves
build stability in the case where you're getting <vector> from  a different
header file then that header removes it.  The build will break in an unexpected
way.

+
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/notifications/notification_delegate.h"
 
 class Profile;
 
 namespace chromeos {
 
 class CupsPrintJob;
 
 // CupsPrintJobNotification is used to update the notification of a print job
@@ skipping 34 matching lines @@
   std::string notification_id_;
   CupsPrintJob* print_job_;
   scoped_refptr<NotificationDelegate> delegate_;
   Profile* profile_;
 
   // If the notification has been closed in the middle of printing or not. If it
   // is true, then prevent the following print job progress update after close,
   // and only show the print job done or failed notification.
   bool closed_in_middle_ = false;
 
+  // If this is true, the user cancelled the job using the cancel button and
+  // should not be notified of events.
+  bool cancelled_by_user_ = false;
+
   // Maintains a list of button actions according to the print job's current
   // status.
   std::unique_ptr<std::vector<ButtonCommand>> button_commands_;
 
   DISALLOW_COPY_AND_ASSIGN(CupsPrintJobNotification);

[xdai1, 2017/02/24 23:31:52]

Do you also need include "base/macros.h" since you're adding included header
files?

[skau, 2017/02/25 00:16:05]

Done.

 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_PRINTING_CUPS_PRINT_JOB_NOTIFICATION_H_