Update documentation of Object.hashCode.

Update documentation of Object.hashCode.

Fixes #28844

BUG= http://dartbug.com/28844
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/804f3dfdd8c4cbe3cc2c517f98b7d4a192256a0e

[Lasse Reichstein Nielsen, 2017-02-22 15:28:28]

lrn@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2017-02-22 16:48:01]

LGTM.

https://codereview.chromium.org/2708233003/diff/1/sdk/lib/core/object.dart
File sdk/lib/core/object.dart (right):

https://codereview.chromium.org/2708233003/diff/1/sdk/lib/core/object.dart#ne...
sdk/lib/core/object.dart:54: * if at least one of the objects were modified.
was

https://codereview.chromium.org/2708233003/diff/1/sdk/lib/core/object.dart#ne...
sdk/lib/core/object.dart:70: * equal to themselves (see [identityHashCode]).
identical to themselves

[Lasse Reichstein Nielsen, 2017-02-22 17:44:13]

https://codereview.chromium.org/2708233003/diff/1/sdk/lib/core/object.dart
File sdk/lib/core/object.dart (right):

https://codereview.chromium.org/2708233003/diff/1/sdk/lib/core/object.dart#ne...
sdk/lib/core/object.dart:54: * if at least one of the objects were modified.
I would say that "were" binds to the nearest preceeding noun, which is
"objects".

https://codereview.chromium.org/2708233003/diff/1/sdk/lib/core/object.dart#ne...
sdk/lib/core/object.dart:70: * equal to themselves (see [identityHashCode]).
All objects are identical to themselves, the default == also only consider
objects *equal* to themselves (that is, only equal if identical).

[floitsch, 2017-02-22 17:46:45]

https://codereview.chromium.org/2708233003/diff/1/sdk/lib/core/object.dart
File sdk/lib/core/object.dart (right):

https://codereview.chromium.org/2708233003/diff/1/sdk/lib/core/object.dart#ne...
sdk/lib/core/object.dart:54: * if at least one of the objects were modified.
On 2017/02/22 17:44:13, Lasse Reichstein Nielsen wrote:
> I would say that "were" binds to the nearest preceeding noun, which is
> "objects".

The subject is "one", and the "of the objects" is just a qualifier. You could
write "at least one was modified".

https://codereview.chromium.org/2708233003/diff/1/sdk/lib/core/object.dart#ne...
sdk/lib/core/object.dart:70: * equal to themselves (see [identityHashCode]).
On 2017/02/22 17:44:13, Lasse Reichstein Nielsen wrote:
> All objects are identical to themselves, the default == also only consider
> objects *equal* to themselves (that is, only equal if identical).

Then change it to: equal to themselves if they are identical.

[Lasse Reichstein Nielsen, 2017-02-23 08:26:12]

https://codereview.chromium.org/2708233003/diff/1/sdk/lib/core/object.dart
File sdk/lib/core/object.dart (right):

https://codereview.chromium.org/2708233003/diff/1/sdk/lib/core/object.dart#ne...
sdk/lib/core/object.dart:54: * if at least one of the objects were modified.
On 2017/02/22 17:46:45, floitsch wrote:
> On 2017/02/22 17:44:13, Lasse Reichstein Nielsen wrote:
> > I would say that "were" binds to the nearest preceeding noun, which is
> > "objects".
> 
> The subject is "one", and the "of the objects" is just a qualifier. You could
> write "at least one was modified".

Done.

https://codereview.chromium.org/2708233003/diff/1/sdk/lib/core/object.dart#ne...
sdk/lib/core/object.dart:70: * equal to themselves (see [identityHashCode]).
That would be redundant - objects are identical to themselves (the "themselves"
refers to the same object).
Rewritten to "equal if they are identical" - still not perfect, but it's hard to
use "objects" (plural) and "are the same object" without getting into the
distinction between objects and references to objects (the references are
identical, but there is only one object, so "objects" cannot be identical).

[Lasse Reichstein Nielsen, 2017-02-28 10:48:44]

Description was changed from

==========
Update documentation of Object.hashCode.

Fixes #28844

BUG= http://dartbug.com/28844
==========

to

==========
Update documentation of Object.hashCode.

Fixes #28844

BUG= http://dartbug.com/28844
R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/804f3dfdd8c4cbe3cc2c517f98b7d4a192256a0e
==========

[Lasse Reichstein Nielsen, 2017-02-28 10:48:45]

Committed patchset #2 (id:20001) manually as
804f3dfdd8c4cbe3cc2c517f98b7d4a192256a0e (presubmit successful).