cc: Move gpu rasterization flag from LayerImpl to LayerTreeImpl.

cc: Move gpu rasterization flag from LayerImpl to LayerTreeImpl.

BUG=367198
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269576

[alokp, 2014-05-08 21:29:31]

I will rip out the rasterizer delegate and add mechanism for switching
rasterizer in a follow-up patch. This patch should not change anything
functionally. It just consolidates the gpu-rasterization from individual
layer-impls to layer-impl-tree.

[reveman, 2014-05-08 21:51:30]

https://codereview.chromium.org/270823003/diff/1/cc/layers/picture_layer_impl.h
File cc/layers/picture_layer_impl.h (right):

https://codereview.chromium.org/270823003/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.h:134: bool UseGpuRasterization() const;
should we just get rid of this completely and use
layer_tree_impl()->use_gpu_rasterization() directly? I think that makes it more
clear that it's a tree specific setting and never different between layers.

[alokp, 2014-05-08 22:44:41]

https://codereview.chromium.org/270823003/diff/1/cc/layers/picture_layer_impl.h
File cc/layers/picture_layer_impl.h (right):

https://codereview.chromium.org/270823003/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.h:134: bool UseGpuRasterization() const;
I will prefer to keep this convenience function for now. It is used at multiple
places, some of which will go away once we can switch out the rasterizer.

[reveman, 2014-05-08 23:08:33]

https://codereview.chromium.org/270823003/diff/1/cc/layers/picture_layer_impl.h
File cc/layers/picture_layer_impl.h (right):

https://codereview.chromium.org/270823003/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.h:134: bool UseGpuRasterization() const;
On 2014/05/08 22:44:41, Alok Priyadarshi wrote:
> I will prefer to keep this convenience function for now. It is used at
multiple
> places, some of which will go away once we can switch out the rasterizer.

Ok in that case, could it be inlined and named use_gpu_rasterization?

[alokp, 2014-05-08 23:34:43]

https://codereview.chromium.org/270823003/diff/1/cc/layers/picture_layer_impl.h
File cc/layers/picture_layer_impl.h (right):

https://codereview.chromium.org/270823003/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.h:134: bool UseGpuRasterization() const;
On 2014/05/08 23:08:33, reveman wrote:
> On 2014/05/08 22:44:41, Alok Priyadarshi wrote:
> > I will prefer to keep this convenience function for now. It is used at
> multiple
> > places, some of which will go away once we can switch out the rasterizer.
> 
> Ok in that case, could it be inlined and named use_gpu_rasterization?

Done.

[reveman, 2014-05-09 00:44:43]

lgtm

[ernstm, 2014-05-09 00:49:11]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-05-09 00:50:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alokp@chromium.org/270823003/20001

[commit-bot: I haz the power, 2014-05-09 04:33:06]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[alokp, 2014-05-09 05:26:21]

The CQ bit was unchecked by alokp@chromium.org

[alokp, 2014-05-09 05:27:39]

Manfred: I would like to wait until enne@ has had a chance to look at it.

[enne (OOO), 2014-05-09 19:13:27]

https://codereview.chromium.org/270823003/diff/20001/cc/trees/layer_tree_host...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/270823003/diff/20001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl.cc:339:
SendReleaseResourcesRecursive(pending_tree_->root_layer());
I think you should have the tree do this internally when you change the "use gpu
rasterization" setting.

[alokp, 2014-05-09 19:59:54]

https://codereview.chromium.org/270823003/diff/20001/cc/trees/layer_tree_host...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/270823003/diff/20001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl.cc:339:
SendReleaseResourcesRecursive(pending_tree_->root_layer());
On 2014/05/09 19:13:27, enne wrote:
> I think you should have the tree do this internally when you change the "use
gpu
> rasterization" setting.

Done.

[enne (OOO), 2014-05-09 20:01:28]

Thanks! That looks a lot cleaner.  :)

lgtm

[alokp, 2014-05-09 20:18:16]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2014-05-09 20:23:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alokp@chromium.org/270823003/60001

[commit-bot: I haz the power, 2014-05-09 21:02:31]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-09 21:07:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 21:07:45]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[alokp, 2014-05-09 21:40:37]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2014-05-09 21:42:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alokp@chromium.org/270823003/80001

[commit-bot: I haz the power, 2014-05-10 01:12:12]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-10 01:16:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-10 01:16:57]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[alokp, 2014-05-10 02:05:03]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2014-05-10 02:07:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alokp@chromium.org/270823003/80001

[commit-bot: I haz the power, 2014-05-10 03:36:22]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-10 04:50:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-10 04:50:51]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[alokp, 2014-05-10 04:54:01]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2014-05-10 04:54:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alokp@chromium.org/270823003/80001

[commit-bot: I haz the power, 2014-05-10 06:26:51]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-10 12:15:50]

Change committed as 269576