Issue 27082003: Build fix for chromium shared component build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27082003: Build fix for chromium shared component build (Closed)

Created:
7 years, 2 months ago by Justin Novosad

Modified:
7 years, 2 months ago

Reviewers:
bungeman-skia, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
		src/core/SkRefCnt.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Justin Novosad

Committed patchset #1 manually as r11827 (presubmit successful).

7 years, 2 months ago (2013-10-16 19:15:39 UTC) #1

reed1

On 2013/10/16 19:15:39, junov wrote: > Committed patchset #1 manually as r11827 (presubmit successful). ??? ...

7 years, 2 months ago (2013-10-16 19:20:42 UTC) #2

Justin Novosad

On 2013/10/16 19:20:42, reed1 wrote: > On 2013/10/16 19:15:39, junov wrote: > > Committed patchset ...

7 years, 2 months ago (2013-10-16 19:24:54 UTC) #3

reed1

7 years, 2 months ago (2013-10-16 19:30:58 UTC) #4

Message was sent while issue was closed.

Bunge thinks this is actually a bug in window's copiler (yes?), so perhaps we
can make this win-only.