Adds ability to sort the children of a node in the bookmark model. I...

Adds ability to sort the children of a node in the bookmark model. I
plan on doing this in chunks, next phase is updating observers, then
changing the bookmark manager to call into the new method.

BUG=1750
TEST=none yet


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10313

[ncarter (slow), 2009-02-24 18:59:06]

http://codereview.chromium.org/27082/diff/1/5
File chrome/views/tree_node_model.h (right):

http://codereview.chromium.org/27082/diff/1/5#newcode150
Line 150: std::vector<NodeType*>& children() { return children_.get(); }
It seems unfortunate to have both the GetChildren() and children() getters. 
Would it make sense to unify them (e.g. GetChildren() returns a const ref, and
has a protected non-const version too)?

[ncarter (slow), 2009-02-24 22:20:14]

On 2009/02/24 18:59:06, nick wrote:
> http://codereview.chromium.org/27082/diff/1/5
> File chrome/views/tree_node_model.h (right):
> 
> http://codereview.chromium.org/27082/diff/1/5#newcode150
> Line 150: std::vector<NodeType*>& children() { return children_.get(); }
> It seems unfortunate to have both the GetChildren() and children() getters. 
> Would it make sense to unify them (e.g. GetChildren() returns a const ref, and
> has a protected non-const version too)?

Actually -- it looks like GetChildren() is currently unused, so maybe we can
just nuke it?

[ncarter (slow), 2009-02-24 23:58:49]

LGTM