Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Issue 27082: Adds ability to sort the children of a node in the bookmark model. I... (Closed)

Created:
11 years, 10 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adds ability to sort the children of a node in the bookmark model. I plan on doing this in chunks, next phase is updating observers, then changing the bookmark manager to call into the new method. BUG=1750 TEST=none yet Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10313

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -16 lines) Patch
M chrome/browser/bookmarks/bookmark_model.h View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_unittest.cc View 12 chunks +42 lines, -10 lines 0 comments Download
M chrome/views/tree_node_model.h View 1 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
11 years, 10 months ago (2009-02-24 05:11:13 UTC) #1
ncarter (slow)
http://codereview.chromium.org/27082/diff/1/5 File chrome/views/tree_node_model.h (right): http://codereview.chromium.org/27082/diff/1/5#newcode150 Line 150: std::vector<NodeType*>& children() { return children_.get(); } It seems ...
11 years, 10 months ago (2009-02-24 18:59:06 UTC) #2
ncarter (slow)
On 2009/02/24 18:59:06, nick wrote: > http://codereview.chromium.org/27082/diff/1/5 > File chrome/views/tree_node_model.h (right): > > http://codereview.chromium.org/27082/diff/1/5#newcode150 > ...
11 years, 10 months ago (2009-02-24 22:20:14 UTC) #3
ncarter (slow)
11 years, 10 months ago (2009-02-24 23:58:49 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698