Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: chrome/browser/sync/sync_global_error.cc

Issue 2708073002: Removing pre-material design menu setting. (Closed)
Patch Set: Removing header Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/sync_global_error.h" 5 #include "chrome/browser/sync/sync_global_error.h"
6 6
7 #include "chrome/app/chrome_command_ids.h" 7 #include "chrome/app/chrome_command_ids.h"
8 #include "chrome/browser/sync/sync_ui_util.h" 8 #include "chrome/browser/sync/sync_ui_util.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/browser_commands.h" 10 #include "chrome/browser/ui/browser_commands.h"
11 #include "chrome/browser/ui/chrome_pages.h" 11 #include "chrome/browser/ui/chrome_pages.h"
12 #include "chrome/browser/ui/global_error/global_error_service.h"
13 #include "chrome/browser/ui/webui/signin/login_ui_service.h" 12 #include "chrome/browser/ui/webui/signin/login_ui_service.h"
14 #include "chrome/common/url_constants.h" 13 #include "chrome/common/url_constants.h"
15 #include "chrome/grit/generated_resources.h" 14 #include "chrome/grit/generated_resources.h"
16 #include "components/browser_sync/profile_sync_service.h" 15 #include "components/browser_sync/profile_sync_service.h"
17 #include "components/signin/core/common/profile_management_switches.h" 16 #include "components/signin/core/common/profile_management_switches.h"
18 #include "google_apis/gaia/google_service_auth_error.h" 17 #include "google_apis/gaia/google_service_auth_error.h"
19 #include "ui/base/l10n/l10n_util.h" 18 #include "ui/base/l10n/l10n_util.h"
20 19
21 SyncGlobalError::SyncGlobalError( 20 SyncGlobalError::SyncGlobalError(
22 GlobalErrorService* global_error_service,
23 LoginUIService* login_ui_service, 21 LoginUIService* login_ui_service,
24 syncer::SyncErrorController* error_controller, 22 syncer::SyncErrorController* error_controller,
25 browser_sync::ProfileSyncService* profile_sync_service) 23 browser_sync::ProfileSyncService* profile_sync_service)
26 : global_error_service_(global_error_service), 24 : login_ui_service_(login_ui_service),
27 login_ui_service_(login_ui_service),
28 error_controller_(error_controller), 25 error_controller_(error_controller),
29 sync_service_(profile_sync_service) { 26 sync_service_(profile_sync_service) {
30 DCHECK(sync_service_); 27 DCHECK(sync_service_);
31 error_controller_->AddObserver(this); 28 error_controller_->AddObserver(this);
32 if (!switches::IsMaterialDesignUserMenu())
33 global_error_service_->AddUnownedGlobalError(this);
34 } 29 }
35 30
36 SyncGlobalError::~SyncGlobalError() { 31 SyncGlobalError::~SyncGlobalError() {
37 DCHECK(!error_controller_) 32 DCHECK(!error_controller_)
38 << "SyncGlobalError::Shutdown() was not called"; 33 << "SyncGlobalError::Shutdown() was not called";
39 } 34 }
40 35
41 void SyncGlobalError::Shutdown() { 36 void SyncGlobalError::Shutdown() {
42 if (!switches::IsMaterialDesignUserMenu())
43 global_error_service_->RemoveUnownedGlobalError(this);
44 error_controller_->RemoveObserver(this); 37 error_controller_->RemoveObserver(this);
45 error_controller_ = nullptr; 38 error_controller_ = nullptr;
46 } 39 }
47 40
48 bool SyncGlobalError::HasMenuItem() { 41 bool SyncGlobalError::HasMenuItem() {
49 return !menu_label_.empty(); 42 return !menu_label_.empty();
50 } 43 }
51 44
52 int SyncGlobalError::MenuItemCommandID() { 45 int SyncGlobalError::MenuItemCommandID() {
53 return IDC_SHOW_SYNC_ERROR; 46 return IDC_SHOW_SYNC_ERROR;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 84
92 void SyncGlobalError::BubbleViewAcceptButtonPressed(Browser* browser) { 85 void SyncGlobalError::BubbleViewAcceptButtonPressed(Browser* browser) {
93 ExecuteMenuItem(browser); 86 ExecuteMenuItem(browser);
94 } 87 }
95 88
96 void SyncGlobalError::BubbleViewCancelButtonPressed(Browser* browser) { 89 void SyncGlobalError::BubbleViewCancelButtonPressed(Browser* browser) {
97 NOTREACHED(); 90 NOTREACHED();
98 } 91 }
99 92
100 void SyncGlobalError::OnErrorChanged() { 93 void SyncGlobalError::OnErrorChanged() {
101 if (switches::IsMaterialDesignUserMenu())
102 return;
103
104 base::string16 menu_label;
105 base::string16 bubble_message;
106 base::string16 bubble_accept_label;
107 sync_ui_util::GetStatusLabelsForSyncGlobalError(
108 sync_service_, &menu_label, &bubble_message, &bubble_accept_label);
109
110 // All the labels should be empty or all of them non-empty.
111 DCHECK((menu_label.empty() && bubble_message.empty() &&
112 bubble_accept_label.empty()) ||
113 (!menu_label.empty() && !bubble_message.empty() &&
114 !bubble_accept_label.empty()));
115
116 if (menu_label != menu_label_ || bubble_message != bubble_message_ ||
117 bubble_accept_label != bubble_accept_label_) {
118 menu_label_ = menu_label;
119 bubble_message_ = bubble_message;
120 bubble_accept_label_ = bubble_accept_label;
121
122 global_error_service_->NotifyErrorsChanged(this);
123 }
124 } 94 }
OLDNEW
« no previous file with comments | « chrome/browser/sync/sync_global_error.h ('k') | chrome/browser/sync/sync_global_error_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698