Chromium Code Reviews| Index: chrome/browser/resources/settings/appearance_page/appearance_page.html |
| diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html |
| index de371637cdd07c02d35d787acee1262dbc047ee6..ac2a02450404d0b3c51066647569adf92e64cded 100644 |
| --- a/chrome/browser/resources/settings/appearance_page/appearance_page.html |
| +++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html |
| @@ -111,11 +111,11 @@ |
| hidden="[[!pageVisibility.homeButton]]"> |
| <settings-radio-group pref="{{prefs.homepage_is_newtabpage}}"> |
| <controlled-radio-button class="list-item" name="true" |
| - pref="[[prefs.homepage_is_newtabpage]]"> |
| + pref="[[prefs.homepage_is_newtabpage]]" ignore-extensions> |
| $i18n{homePageNtp} |
| </controlled-radio-button> |
| <controlled-radio-button class="list-item" name="false" |
| - pref="[[prefs.homepage_is_newtabpage]]"> |
| + pref="[[prefs.homepage_is_newtabpage]]" ignore-extensions> |
|
dschuyler
2017/02/28 00:15:18
ignore-extensions on line 114 and 118 may not be s
stevenjb
2017/02/28 02:59:33
I would rather error on the side of more icons tha
Dan Beam
2017/02/28 19:51:36
that's not your call, unless you changed to our de
stevenjb
2017/02/28 19:56:28
I was under the assumption that we didn't have des
|
| $i18n{other} |
| <!-- TODO(dbeam): this can show double indicators when both |
| homepage and whether to use the NTP as the homepage are |
| @@ -123,7 +123,7 @@ |
| <settings-input no-label-float pref="{{prefs.homepage}}" |
| label="$i18n{exampleDotCom}" |
| can-tab="[[!prefs.homepage_is_newtabpage.value]]" |
| - stop-keyboard-event-propagation> |
| + stop-keyboard-event-propagation ignore-extensions> |
| </settings-input> |
| </controlled-radio-button> |
| <template is="dom-if" if="[[prefs.homepage.extensionId]]"> |