ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.h - Issue 2708013002: [ios clean] Creates ToolbarWebState Mediator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.h

Issue 2708013002: [ios clean] Creates ToolbarWebState Mediator (Closed)

Patch Set: Renaming feedback Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/clean/chrome/browser/ui/toolbar/toolbar_consumer.h ('k') | ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm » ('j') | ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // ====== New Architecture =====	5 // ====== New Architecture =====

6 // = This code is only used in the new iOS Chrome architecture. =	6 // = This code is only used in the new iOS Chrome architecture. =

7 // ============================================================================	7 // ============================================================================

8	8

9 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_COORDINATOR_H_	9 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_COORDINATOR_H_

10 #define IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_COORDINATOR_H_	10 #define IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_COORDINATOR_H_

11	11

12 #import "ios/clean/chrome/browser/browser_coordinator.h"	12 #import "ios/clean/chrome/browser/browser_coordinator.h"

13 #import "ios/web/public/web_state/web_state_observer_bridge.h"	13

	14 namespace web {

	15 class WebState;

	16 }

14	17

15 // Coordinator to run a toolbar -- a UI element housing controls.	18 // Coordinator to run a toolbar -- a UI element housing controls.

16 @interface ToolbarCoordinator : BrowserCoordinator<CRWWebStateObserver>	19 @interface ToolbarCoordinator : BrowserCoordinator

	20 // The web state this ToolbarCoordinator is handling.

	21 @property(nonatomic, assign) web::WebState* webState;
	edchin 2017/02/21 18:39:08 If this webState is required, consider a custom in If this webState is required, consider a custom initializer. sczs 2017/02/21 19:04:09 I was thinking the exact same thing! But I'm not s Show quoted text On 2017/02/21 18:39:08, edchin wrote: > If this webState is required, consider a custom initializer. I was thinking the exact same thing! But I'm not sure what's our policy on custom initializers for Coordinators, and since Mark didn't create one for web I thought we should keep things similar.
17 @end	22 @end

18	23

19 #endif // IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_COORDINATOR_H_	24 #endif // IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_COORDINATOR_H_

OLD	NEW