ios/clean/chrome/browser/ui/toolbar/toolbar_web_state_consumer.h - Issue 2708013002: [ios clean] Creates ToolbarWebState Mediator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/toolbar/toolbar_web_state_consumer.h

Issue 2708013002: [ios clean] Creates ToolbarWebState Mediator (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/clean/chrome/browser/ui/toolbar/toolbar_coordinator.mm ('K') | « ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm ('k') | ios/clean/chrome/browser/ui/toolbar/toolbar_web_state_mediator.h » ('j') | ios/clean/chrome/browser/ui/toolbar/toolbar_web_state_mediator.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_WEB_STATE_CONSUMER_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_WEB_STATE_CONSUMER_H_

	7

	8 #import <UIKit/UIKit.h>

	9

	10 // ToolbarWebStateConsumer sets the current appeareance of the Toolbar based on
	edchin 2017/02/21 07:56:11 nit: spelling. appearance. nit: spelling. appearance. sczs 2017/02/21 17:28:27 Done. Show quoted text On 2017/02/21 07:56:11, edchin wrote: > nit: spelling. appearance. Done.
	11 // WebState information provided by this protocol.

	12 @protocol ToolbarWebStateConsumer
	marq (ping after 24h) 2017/02/21 12:04:24 The general model I'd like to adopt is that the vi The general model I'd like to adopt is that the view controller defines a coordinator protocol for all of the properties it needs to be provided with. Those shouldn't be connected to any particular data source. The mediator's job is to take one or more data sources and combine information and events from them into updates for the consumer. With that in mind, this should just be 'ToolbarConsumer', and the mediator will just be 'ToolbarMediator'. The mediator will happen to accept a webState as its input, but that's essentially an implementation detail. sczs 2017/02/21 17:28:27 Done. Show quoted text On 2017/02/21 12:04:24, marq wrote: > The general model I'd like to adopt is that the view controller defines a > coordinator protocol for all of the properties it needs to be provided with. > Those shouldn't be connected to any particular data source. The mediator's job > is to take one or more data sources and combine information and events from them > into updates for the consumer. > > With that in mind, this should just be 'ToolbarConsumer', and the mediator will > just be 'ToolbarMediator'. The mediator will happen to accept a webState as its > input, but that's essentially an implementation detail. Done.
	13 // Sets the text for a label appearing in the center of the toolbar.

	14 - (void)setCurrentPageText:(NSString*)text;

	15 @end

	16

	17 #endif // IOS_CLEAN_CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_WEB_STATE_CONSUMER_H_

OLD	NEW