[Android]: Hide add-to-homescreen app menu item when WebAPK is installed

chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.metrics;
 
 import org.chromium.base.metrics.RecordHistogram;
 
 /**
  * Centralizes UMA data collection for WebAPKs. NOTE: Histogram names and values are defined in
@@ skipping 11 matching lines @@
     public static final int UPDATE_REQUEST_QUEUED_ONCE = 0;
     public static final int UPDATE_REQUEST_QUEUED_TWICE = 1;
     public static final int UPDATE_REQUEST_QUEUED_THREE_TIMES = 2;
     public static final int UPDATE_REQUEST_QUEUED_MAX = 3;
 
     public static final String HISTOGRAM_UPDATE_REQUEST_SENT =
             "WebApk.Update.RequestSent";
 
     public static final String HISTOGRAM_UPDATE_REQUEST_QUEUED = "WebApk.Update.RequestQueued";
 
+    public static final int WEBAPK_OPEN_LAUNCH_SUCCESS = 0;

[nyquist, 2017/02/28 07:04:19]

Could you add a comment about this enum that refers to the UMA stat?

[gonzalon, 2017/02/28 16:12:23]

Done.

+    public static final int WEBAPK_OPEN_NO_LAUNCH_INTENT = 1;
+    public static final int WEBAPK_OPEN_ACTIVITY_NOT_FOUND = 2;
+    public static final int WEBAPK_OPEN_MAX = 3;
+
     /**
      * Records the time point when a request to update a WebAPK is sent to the WebAPK Server.
      * @param type representing when the update request is sent to the WebAPK server.
      */
     public static void recordUpdateRequestSent(int type) {
         assert type >= 0 && type < UPDATE_REQUEST_SENT_MAX;
         RecordHistogram.recordEnumeratedHistogram(HISTOGRAM_UPDATE_REQUEST_SENT,
                 type, UPDATE_REQUEST_SENT_MAX);
     }
 
     /**
      * Records the times that an update request has been queued once, twice and three times before
      * sending to WebAPK server.
      * @param times representing the times that an update has been queued.
      */
     public static void recordUpdateRequestQueued(int times) {
         RecordHistogram.recordEnumeratedHistogram(HISTOGRAM_UPDATE_REQUEST_QUEUED, times,
                 UPDATE_REQUEST_QUEUED_MAX);
     }
+
+    /**
+     * When a user presses on the "Open WebAPK" menu item, this records whether the WebAPK was
+     * opened successfully.
+     * @param type Result of trying to open WebAPK.
+     */
+    public static void recordWebApkOpenAttempt(int type) {

[nyquist, 2017/02/28 07:04:19]

Any reason this isn't documented using @IntDef? Seems like that could be helpful
here.

[gonzalon, 2017/02/28 16:12:23]

I just followed the style on this file, I added the @IntDef annotation, but
please let me know if I missed something since this is the first time I've used
it. It does look like a good alternative to an enum, but what advantage does it
have over using one and calling it's #ordinal method? Is it performance reasons?

[nyquist, 2017/02/28 17:57:17]

Yeah, it's just for performance reasons.

+        assert type >= 0 && type < WEBAPK_OPEN_MAX;
+        RecordHistogram.recordEnumeratedHistogram("WebApk.OpenFromMenu", type, WEBAPK_OPEN_MAX);
+    }
 }