Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2707973008: Fix some parser issues related to generic functin types (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some parser issues related to generic functin types R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/442e3849e10ad5738ee5a5dfbfef882ce440dbb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M pkg/analyzer/lib/src/dart/error/syntactic_errors.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-02-22 20:44:01 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-02-22 20:46:26 UTC) #3
Brian Wilkerson
3 years, 10 months ago (2017-02-22 20:50:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
442e3849e10ad5738ee5a5dfbfef882ce440dbb4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698