ios/chrome/browser/ui/omnibox/omnibox_view_ios.h - Issue 2707963002: [ObjC ARC] Converts ios/chrome/browser/ui/omnibox:omnibox_internal to ARC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/omnibox/omnibox_view_ios.h

Issue 2707963002: [ObjC ARC] Converts ios/chrome/browser/ui/omnibox:omnibox_internal to ARC. (Closed)

Patch Set: weaks Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/omnibox/omnibox_view_ios.h

diff --git a/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h b/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h

index 8a99c43018940de96a284a281733504374fc632b..02dd8c36327b57bb69d62516d28c9b7ea6e135f1 100644

--- a/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h

+++ b/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h

@@ -153,7 +153,8 @@ class OmniboxViewIOS : public OmniboxView {

base::scoped_nsobject<OmniboxTextFieldIOS> field_;

WebOmniboxEditController* controller_; // weak, owns us

std::unique_ptr<OmniboxPopupViewIOS> popup_view_;

- id<PreloadProvider> preloader_;

+ __unsafe_unretained id<PreloadProvider>

+ preloader_; // Should be __weak but is included from non-ARC code.

rohitrao (ping after 24h) 2017/02/24 13:40:32 Same comment about moving the comment to its own l

stkhapugin 2017/03/01 17:43:58 Done.

State state_before_change_;

base::scoped_nsobject<NSString> marked_text_before_change_;